Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure valid key validation is enabled for all components #493

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 31, 2023

Turns out after all my hard work on enabling validation most components weren't actually validating the keys of the spec.

Fixes #487

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #493 (af75dbf) into main (592e75b) will increase coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   69.36%   69.41%   +0.04%     
==========================================
  Files          79       79              
  Lines        9128     9159      +31     
==========================================
+ Hits         6332     6358      +26     
- Misses       2796     2801       +5     
Files Coverage Δ
lumen/base.py 84.63% <100.00%> (+0.09%) ⬆️
lumen/filters/base.py 71.33% <100.00%> (+0.09%) ⬆️
lumen/layout.py 79.13% <100.00%> (-0.38%) ⬇️
lumen/pipeline.py 64.61% <100.00%> (+0.09%) ⬆️
lumen/sources/base.py 62.74% <100.00%> (-0.11%) ⬇️
lumen/tests/test_dashboard.py 100.00% <ø> (ø)
lumen/tests/validation/test_filters.py 100.00% <100.00%> (ø)
lumen/tests/validation/test_layout.py 100.00% <100.00%> (ø)
lumen/tests/validation/test_pipeline.py 100.00% <100.00%> (ø)
lumen/tests/validation/test_sources.py 100.00% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 49762cd into main Oct 31, 2023
10 checks passed
@philippjfr philippjfr deleted the key_validation_fixes branch October 31, 2023 22:45
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate method does not notify on issues
2 participants