Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounds to limit #484

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Add bounds to limit #484

merged 4 commits into from
Oct 31, 2023

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Sep 5, 2023

Closes #483

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #484 (f6d943e) into main (592e75b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   69.36%   69.36%           
=======================================
  Files          79       79           
  Lines        9128     9128           
=======================================
  Hits         6332     6332           
  Misses       2796     2796           
Files Coverage Δ
lumen/views/base.py 65.05% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ahuang11 ahuang11 added this to the 0.6.0 milestone Sep 18, 2023
@philippjfr
Copy link
Member

It's valid to select zero rows so the correct setting should be bounds=(0, None).

lumen/views/base.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit 0cc09eb into main Oct 31, 2023
10 checks passed
@philippjfr philippjfr deleted the add_limit_bounds branch October 31, 2023 22:45
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit should have a bounds set
4 participants