Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Enable conventional commits #6397

Merged
merged 7 commits into from
Nov 13, 2024
Merged

ci: Enable conventional commits #6397

merged 7 commits into from
Nov 13, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 28, 2024 •
edited
Loading

Will merge it after the next release

@hoxbro hoxbro marked this pull request as draft September 28, 2024 07:49
@hoxbro hoxbro marked this pull request as ready for review November 4, 2024 11:51
maximlt
maximlt reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the contributor guide need to be updated?

@hoxbro
Copy link
Member Author

hoxbro commented Nov 4, 2024

Does the contributor guide need to be updated?

Done in cf0ce35

@hoxbro hoxbro requested a review from maximlt November 7, 2024 15:09
maximlt
maximlt approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping that this won't be used to automatically generate the release notes ;)

@hoxbro hoxbro merged commit c227510 into main Nov 13, 2024
7 checks passed
@hoxbro hoxbro deleted the conventional_commits branch November 13, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximlt maximlt maximlt approved these changes

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoxbro @maximlt