Added warning when datashading with multi_y=True #5829
Conversation
|
Note that I am hardcoding 'bokeh' as the backend: |
Codecov Report
@@ Coverage Diff @@
## main #5829 +/- ##
==========================================
- Coverage 88.23% 88.23% -0.01%
==========================================
Files 309 309
Lines 63866 63872 +6
==========================================
+ Hits 56354 56359 +5
- Misses 7512 7513 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| def __call__(self, element, **kwargs): | ||
| opts = element.opts.get('plot', 'bokeh') | ||
| opts = {} if opts is None else opts.kwargs | ||
| if 'multi_y' in opts: |
There was a problem hiding this comment.
| if 'multi_y' in opts: | |
| if 'multi_y' in opts and isinstance(element, CompositeOverlay): |
There was a problem hiding this comment.
Not sure that's quite right, but I don't see a good reason to warn if you just provide an Element. Also the multi_y may be set after the fact and then this warning won't do anything. So overall I don't think this approach is very good.
There was a problem hiding this comment.
Fair enough. Where would you warn from when using datashader with multi_y=True then?
There was a problem hiding this comment.
One other alternative of course is to not warn at all and to document this instead...
Simple PR to address #5823
Now that
RangeXYis extra axis aware, you still need to overlay rasterize calls to datashade withmulti_y=True. This PR adds such a warning/suggestion for the user until we can support aRangeXMultiYstream (or similar).