Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotators fields if none is provided to the connector #24

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 19, 2023

I'm not sure we should keep having fields in the Connector.

This makes it possible to do this:

from holonote.annotate import Annotator, SQLiteDB

fields = ["ProductionStoppage", "Reason", "Category"]
connector = SQLiteDB(filename=":memory:")
# instead of 
# connector = SQLiteDB(filename=":memory:", fields=fields)

annotator = Annotator({"TIME": float}, fields=fields, connector=connector)

@hoxbro hoxbro merged commit 1615a2a into main Sep 20, 2023
14 checks passed
@hoxbro hoxbro deleted the sync_fields branch September 20, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant