-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edit stream and make popup more robust #117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
commented
Jun 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 86.18% 86.16% -0.03%
==========================================
Files 24 24
Lines 2592 2595 +3
==========================================
+ Hits 2234 2236 +2
- Misses 358 359 +1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #117 will not alter performanceComparing Summary
|
hoxbro
reviewed
Jun 27, 2024
ahuang11
commented
Jun 28, 2024
hoxbro
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #114 and makes the popup more robust across another example (region 2d) not from the tutorial.
Screen.Recording.2024-06-27.at.12.16.29.PM.mov
The clipping of the popup panel at the edge of the plot is a HoloViews/Bokeh issue that will be addressed separately.