Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit stream and make popup more robust #117

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Fix edit stream and make popup more robust #117

merged 4 commits into from
Jun 28, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jun 27, 2024

Closes #114 and makes the popup more robust across another example (region 2d) not from the tutorial.

Screen.Recording.2024-06-27.at.12.16.29.PM.mov

The clipping of the popup panel at the edge of the plot is a HoloViews/Bokeh issue that will be addressed separately.

@ahuang11 ahuang11 requested review from hoxbro and droumis June 27, 2024 19:16
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.16%. Comparing base (f9deb64) to head (9ea5099).

Files Patch % Lines
holonote/app/panel.py 18.51% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   86.18%   86.16%   -0.03%     
==========================================
  Files          24       24              
  Lines        2592     2595       +3     
==========================================
+ Hits         2234     2236       +2     
- Misses        358      359       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 27, 2024

CodSpeed Performance Report

Merging #117 will not alter performance

Comparing fix_edit_stream (9ea5099) with main (f9deb64)

Summary

✅ 6 untouched benchmarks

holonote/annotate/display.py Outdated Show resolved Hide resolved
holonote/app/panel.py Outdated Show resolved Hide resolved
holonote/app/panel.py Outdated Show resolved Hide resolved
holonote/app/panel.py Outdated Show resolved Hide resolved
holonote/app/panel.py Outdated Show resolved Hide resolved
holonote/annotate/display.py Outdated Show resolved Hide resolved
@ahuang11 ahuang11 requested a review from hoxbro June 27, 2024 20:56
@hoxbro hoxbro enabled auto-merge (squash) June 28, 2024 15:12
@hoxbro hoxbro merged commit 0301194 into main Jun 28, 2024
13 checks passed
@hoxbro hoxbro deleted the fix_edit_stream branch June 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit mode when an annotation is selected erroneously allows for creation of new annotation
3 participants