-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: website #106
WIP: website #106
Conversation
Going to try to improve this PR a bit and then upload the build to geoviews.org. @ceball Did anything I need to know about change since this was last built? |
Ah, sorry. I think what happened is I stopped being able to use geoviews on travis, and meant to come back to this PR a bit later (hoping the problem would resolve itself in the meantime), but then I forgot all about it. Sorry! Do you know if the problem shown at https://travis-ci.org/ioam/geoviews/builds/314797817#L2101 has gone away? If so, I'd be happy to rebase this PR and get the build passing before you look at it. |
Actually, I just checked, and it does seem to have gone away. So @philippjfr, just to confirm: I'll rebase and get things passing, then ping you, unless you've started already? |
I haven't started yet, probably won't have time before Friday in any case. |
@philippjfr, should be ok for you to continue with. nbsite hasn't had many of the improvements I'd hoped for yet, so there'll be some things that annoy/confuse you - please just ask me. Maybe you can motivate the next nbsite task I tackle. There are some usage notes for nbsite at https://ioam.github.io/nbsite/Usage.html, but they are still really draft notes. |
Just a warning that a notebook failing to run isn't yet an error for nbsite - you have to notice! One notebook's currently failing: https://travis-ci.org/ioam/geoviews/jobs/327704526#L4581 |
…re conversion to nbsite. Reduce deployment size.
Link should be in Homepage.ipynb instead, but need to do some reorganization that depends on nbsite.
I'm largely happy with this now, the two things I'd like to fix before merging are:
|
Sorry, right now, the only way to turn off the latest news (the twitter feed) is to completely remove it and its hacky outer div. I've done that (waiting for site to build to check it). We could surely do better. But before doing so, I'd like to decide which components of the sites are always going to be present, and how they might vary (ioam/sphinx_ioam_theme#3). E.g. I think the twitter feed is a great way to have "latest news", but you might not necessarily need to have a separate feed for every project.
I'd prefer to merge this PR first and address your request later on (but I'm not saying it's unimportant - the opposite!). |
I'm happy to merge now, and address the nav bar issue once we've discussed it properly. |
Any feedback/suggestions on the color scheme? Also is there a good place to record how to go about building the CSS with a new color scheme? My process is this:
|
Not the final system we want, but should be ok for now.
I like the color scheme/process for picking it. But I'm not a designer :) I've added your useful comment to ioam/sphinx_ioam_theme#1. I'll probably just add all documentation about how to customize stuff to the nbsite website (we'll see...). |
The wrapping is fixed, so I think this PR is ready to be merged. The docs will be re-built every commit, but ioam.github.io/geoviews site will be re-uploaded only when a tag is pushed. We'll come up with a better system, but I think that's ok for now? |
Sounds fine. We may have to revisit once the site gets larger. I never did manage to improve the gallery scripts, but if I wanted to add a Gallery to GeoViews using the existing system, how much work would that be? |
It shouldn't be too bad, and it was requested for datashader too. I think last time I tried it was working for mpl but not bokeh. I didn't investigate more at the time, but I'll try it out soon and get back to you if I need help... |
Thanks for working on this! Looking good already and with some more tweaking this will be great. |
- pip install nbsite | ||
- pip install sphinx_ioam_theme | ||
# TODO: should make this content available too rather than deleting it! | ||
- rm notebooks/*.ipynb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philippjfr, forgot to ask: what's in these notebooks, and should it appear somewhere on the website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think they are old prototypes and can be deleted or updated. They almost certainly require updates.
https://ioam.github.io/geoviews/ is built on pushing to this PR.
To do:
Before merging: