Skip to content
This repository was archived by the owner on Feb 3, 2023. It is now read-only.

Basic start to tokio trace #2132

Merged
merged 31 commits into from
Mar 6, 2020
Merged

Basic start to tokio trace #2132

merged 31 commits into from
Mar 6, 2020

Conversation

freesig
Copy link
Contributor

@freesig freesig commented Feb 25, 2020

PR summary

This is an attempt at adding futures aware tracing.

Todo

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

Detailed usage guide

@freesig freesig marked this pull request as ready for review March 3, 2020 08:40
@freesig
Copy link
Contributor Author

freesig commented Mar 3, 2020

Just need to publish the new version of holochain-tracing and this is ready. Feel free to start reviewing though. I needs some help on deciding which log level things should be. So far most of what I've added is INFO level but maybe it's better as TRACE

@freesig
Copy link
Contributor Author

freesig commented Mar 3, 2020

Also it depends on my fork in holochain-tracing but this isn't on crates so maybe that's not going to go well with nix?

@freesig
Copy link
Contributor Author

freesig commented Mar 3, 2020

Also clippy is failing due to complexity? fixed

Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except the async fixes that need doing.

@freesig
Copy link
Contributor Author

freesig commented Mar 5, 2020

  • Disable logging for stress test
  • Add help to sim2h_server cmd line

@zippy zippy merged commit 9564458 into develop Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants