This repository was archived by the owner on Feb 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into tokio_tracing
…into tokio_tracing
…into tokio_tracing
…into tokio_tracing
Just need to publish the new version of holochain-tracing and this is ready. Feel free to start reviewing though. I needs some help on deciding which log level things should be. So far most of what I've added is INFO level but maybe it's better as TRACE |
|
|
zippy
reviewed
Mar 5, 2020
zippy
reviewed
Mar 5, 2020
zippy
reviewed
Mar 5, 2020
zippy
reviewed
Mar 5, 2020
freesig
commented
Mar 5, 2020
zippy
reviewed
Mar 5, 2020
zippy
reviewed
Mar 5, 2020
zippy
reviewed
Mar 5, 2020
zippy
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except the async fixes that need doing.
|
StaticallyTypedAnxiety
approved these changes
Mar 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This is an attempt at adding futures aware tracing.
Todo
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation
Detailed usage guide