Custom header anchors #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafapaezbas
force-pushed
the
custom-header-anchors
branch
from
5f5cd4d
to
206d193
Compare
rafapaezbas
force-pushed
the
custom-header-anchors
branch
from
206d193
to
e7f7544
Compare
subashsn
approved these changes
Feb 29, 2024
|
Looks good, but suggest the code be reviewed by someone else on the team too as I don't have bg. on it yet. |
freeall
suggested changes
Feb 29, 2024
lib/app-router.js
Outdated
| if (!opts.back) history.pushState({ pathname }, null, pathname) | ||
| await element.load(page, opts) | ||
|
|
||
| if (pathname.startsWith('/documentation') && !!opts.header) { |
There was a problem hiding this comment.
Could you name this guard similar to if (isDocumentationPage)? A little unclear to me what this checks.
lib/app-router.js
Outdated
| const elementY = Math.floor(element.getBoundingClientRect().y) | ||
| const headerHeight = 170 | ||
| const extraScroll = 80 | ||
| if (elementY < headerHeight + extraScroll) { |
There was a problem hiding this comment.
Similar to this check, could you name this?
rafapaezbas
force-pushed
the
custom-header-anchors
branch
from
b135fe9
to
e9b9505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements custom header ids in Marked using https://github.com/markedjs/marked-custom-heading-id, adds the header ids, corrects the indexes and implements the anchor navigation in pear-desktop-app.