Add failing batch test #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should be fixed by holepunchto/hypercore-storage#28 |
|
In addition to this, see the TODO in the storage PR. Instead of enforcing the existance of the head record (implies the tree hash is optional which is weird), we should prop just enforce that a null header means the empty tree in HC |
mafintosh
force-pushed
the
add-failing-test
branch
from
803cd9f
to
2c5fc8d
Compare
mafintosh
force-pushed
the
add-failing-test
branch
from
2c5fc8d
to
7dcd252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.