Copy node-cache entries to reduce mem usage #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDegroote
commented
May 27, 2024
HDegroote
commented
May 27, 2024
|
Marking as draft since there is a failing CI on windows I need to look into (seems like an interaction with tmp-test) Edit: forgot to close the tree, so it was an error in the test itself. Fixed now |
mafintosh
reviewed
May 27, 2024
mafintosh
reviewed
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: random-access-file uses slab-allocated memory by default when reading from disk. Since we store the nodes in a cache, the entire slab is kept from being garbage-collected. This PR copies the cache entry to a new, smaller slab.