all batch sigs are unslabbed always and unslab root hash

lib/core.js

@@ -1,5 +1,6 @@
 const hypercoreCrypto = require('hypercore-crypto')
 const b4a = require('b4a')
+const unslab = require('unslab')
 const Oplog = require('./oplog')
 const BigHeader = require('./big-header')
 const Mutex = require('./mutex')
@@ -184,7 +185,7 @@ module.exports = class Core {
       if (e.treeUpgrade) {
         const batch = await tree.truncate(e.treeUpgrade.length, e.treeUpgrade.fork)
         batch.ancestors = e.treeUpgrade.ancestors
-        batch.signature = e.treeUpgrade.signature
+        batch.signature = e.treeUpgrade.signature === null ? null : unslab(e.treeUpgrade.signature)
         addReorgHint(header.hints.reorgs, tree, batch)
         batch.commit()
 

lib/merkle-tree.js

@@ -138,7 +138,7 @@ class MerkleTreeBatch {
   }
 
   hash () {
-    if (this.hashCached === null) this.hashCached = this.tree.crypto.tree(this.roots)
+    if (this.hashCached === null) this.hashCached = unslab(this.tree.crypto.tree(this.roots))
     return this.hashCached
   }
 
@@ -260,7 +260,7 @@ class MerkleTreeBatch {
     this.tree.length = this.length
     this.tree.byteLength = this.byteLength
     this.tree.fork = this.fork
-    this.tree.signature = this.signature !== null ? unslab(this.signature) : null
+    this.tree.signature = this.signature
   }
 
   seek (bytes, padding) {
@@ -430,7 +430,7 @@ module.exports = class MerkleTree {
     this.roots = roots
     this.length = roots.length ? totalSpan(roots) / 2 : 0
     this.byteLength = totalSize(roots)
-    this.signature = signature !== null ? unslab(signature) : null
+    this.signature = signature
     this.prologue = prologue
 
     this.storage = storage
@@ -471,7 +471,7 @@ module.exports = class MerkleTree {
   }
 
   hash () {
-    return this.crypto.tree(this.roots)
+    return unslab(this.crypto.tree(this.roots))
   }
 
   signable (namespace) {
@@ -982,7 +982,7 @@ function verifyUpgrade ({ fork, upgrade }, blockRoot, batch) {
     ite.sibling()
   }
 
-  batch.signature = upgrade.signature
+  batch.signature = upgrade.signature !== null ? unslab(upgrade.signature) : null
   batch.fork = fork
 
   return q.extra === null

lib/verifier.js

@@ -237,7 +237,7 @@ function defaultQuorum (man) {
 }
 
 function generateUpgrade (patch, start, length) {
-  const upgrade = { start, length, nodes: null, additionalNodes: [] }
+  const upgrade = { start, length, nodes: null, additionalNodes: [], signature: null }
 
   const from = start * 2
   const to = from + length * 2