Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch geeglm() error when starting values specified #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffeaton
Copy link

This PR patches issue #5 that geeglm() threw an error when argument start = was specified.

I also suggested one other small change. For the starting values of geese.fit(), I removed the condition:

  if (is.null(start)) 
    start <- glmFit$coef

So that it instead always uses the coefficients from glmFit as the starting values for geese.fit()

  start <- glmFit$coef

The specified starting values are still used as starting values for the initial glm() fit.

Maybe I am missing something though about why it reverts back to the initial starting values for initialising geese.fit().

Thanks,
Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant