Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RenderTo function, to render directly to a writer. #29

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

drhodes
Copy link

@drhodes drhodes commented Apr 8, 2013

Ok, I synced to your current master and merged. The pull request should now contain only what's relevant to RenderTo. The diff is much cleaner.

After pushing, I realized that the commit message is not what I wanted, tried git --amend, and pushed again, but the message didn't change the way I expected. Looking further, I found some options referring to git push --force as a fix, however it looks dangerous for pull requests.

If you'd like that message changed, I'll look into some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants