Add a comma between two table expression.

[Metalaka]

See Alias syntax in FROM clause.

[Hywan]

Hello :-),

Thank you for the PR! Nevertheless, I would encourage you to use an array $out, combined with an implode(', ', $out), which avoid the use of substr (this is how we made out there in Hoa).

Thanks!

[Metalaka]

I agree, you prefer something like that ?

foreach($this->_from as $alias => &$from)
    if(!is_int($alias))
        $form = $from . ' AS ' . $alias;

$out .= ' ' . implode(', ', $this->_from)

[Hywan]

Something like:

$handle = array();
foreach($this->_from as $alias => $from)
    if(is_int($alias))
        $handle[] = ' ' . $from;
    else
        $handle[] = ' ' . $from . ' AS ' . $alias;
$out = implode(', ', $handle);

This is how we used to do :-).

[Metalaka]

Also modify $this->_from is not a good idea.

I updated the attached commit ;)

[Hywan]

@camael24 will do the review.

[thehawk970]

Sounds good for me

$select->from('foo')->_as('f')->from('bar')->_as('b');
output in Metalaka version : SELECT * FROM foo AS f, bar AS b
instead of Hoa version which output : SELECT * FROM foo AS f bar AS b

[Hywan]

Thanks!