feat: password reset email #471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-email I added the endpoint for users to request for password reset and a link will be sent to the user if the user provides an email that is in the database
…created the file and I did not modify it
…d-email I just made some changes to my pytest
…d-email I just finished fixing my pytest, I pray it works.
joboy-dev
approved these changes
Jul 26, 2024
|
I've been deactivated from the slack channel though! |
joboy-dev
reviewed
Jul 27, 2024
|
|
||
| # Protected route example: test route | ||
| @auth.get("/admin") | ||
| def read_admin_data(current_admin: Annotated[User, Depends(user_service.get_current_super_admin)]): | ||
| return {"message": "Hello, admin!"} | ||
|
|
||
| def generate_access_token(data: dict, expires_delta: Optional[timedelta] = None): |
There was a problem hiding this comment.
From here, all of this needs to be in user service.
Generate access token has been taken care of
There was a problem hiding this comment.
Once it's put there, it does not work again for some reasons I can't explain, so I had to leave the functions in the auth file.
joboy-dev
requested changes
Jul 27, 2024
|
Closing this PR because this endpoint has been implemented and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint allows users to reset their password by providing the password they used in registration.
Description
The endpoint takes the email the user provided and compare it again the record in the database if it matches any email, if it does, it sends a password reset link into the user's email and returns 200 OK status code. If the email does not exist in the database, it returns "We don't have user with the provided email in our database." and 404 status code.
Related Issue (Link to issue ticket)
#51
Motivation and Context
This will allow users to retrieve their email should in case anything happen to their account provided thy know the email address.
How Has This Been Tested?
Yes, I tested it using pytest and Postman.
Screenshots (if appropriate - Postman, etc):
Types of changes
Checklist: