-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(newsletters): add subscribe endpoint #353
Merged
zxenonx
merged 6 commits into
hngprojects:dev
from
Solomonuche:feat/newsletter-subscription
Jul 24, 2024
Merged
feat(newsletters): add subscribe endpoint #353
zxenonx
merged 6 commits into
hngprojects:dev
from
Solomonuche:feat/newsletter-subscription
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joboy-dev
previously approved these changes
Jul 24, 2024
@bolexs this is okay |
SundayMba
previously approved these changes
Jul 24, 2024
@bolexs okay |
Signed-off-by: Solomon Nweke <[email protected]>
Signed-off-by: Solomon Nweke <[email protected]>
Goketech
approved these changes
Jul 24, 2024
zxenonx
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Solomonuche. Good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the implementation of
[POST] /api/v1/newsletters
[UNPROTECTED Endpoint]Description
Develop a backend endpoint to handle requests for newsletter subscriptions. The endpoint will accept an email address, validate and sanitize it, and then handle both successful and failed validations appropriately. If the email passes validation, it will be stored in the database and a 'success' response will be sent to the client. If validation fails, an error message will be returned.
Related Issue (Link to issue ticket)
This is an implementation of an open issue Link
How Has This Been Tested?
This implementation has been thoroughly tested with fastapi openapi interface and postman
Screenshots (if appropriate - Postman, etc):
Successful response
Error response
Checklist: