[feature] Wrote tests for router function #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mely easy and clear to use. So you just import the mail_validator.js file, which returns an object with two things, a validator function and a schema table. It is extremely easy to use and structured in a way you dont have to think about the implementation to use it. The validator is promised based, so if you call it, it resolves a `value` or rejects an `error`. slackName: Joe.Attah Team Fierce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feature] Made couple of changes to the controller function, so it will be easily testable.
Wrote some tests for the function and it is working well.
check to see that all test are passing and emails are delivering.
Also i commented out the debug email part of the mailingController functions, they were breaking the server.
I also took out body parser because express ships with body parser.