Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Extension lib #68

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Update to Extension lib #68

merged 2 commits into from
Oct 23, 2024

Conversation

it-hms
Copy link
Contributor

@it-hms it-hms commented Oct 22, 2024

@it-hms it-hms requested review from alexjhawk and TomKimsey October 22, 2024 20:32
@it-hms
Copy link
Contributor Author

it-hms commented Oct 22, 2024

Build fails because ext lib v1.16.2 is not yet built by automation. Will re-run actions

@it-hms
Copy link
Contributor Author

it-hms commented Oct 23, 2024

@alexjhawk @TomKimsey
Build is passing now that ext lib dependency version is available.

- Update Extension library to v1.16.2
- Fixes issue where local timezone offset is only calculated at startup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the end of the world, but Update Extension library to v1.16.2 on its own isn't really a bug fix.

I think that could be a sub-bullet underneath the 'Fixes issue ...' line (or the other way around)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on the sub bullet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to sub bullet

@it-hms it-hms requested a review from alexjhawk October 23, 2024 14:54
@it-hms it-hms merged commit 2930c68 into main Oct 23, 2024
5 checks passed
@it-hms it-hms deleted the iatr/time branch October 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants