Dev/154 155 #156
Merged
Dev/154 155 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-java-format: version 1.23.0
|
@alexjhawk, These changes still need to be tested |
alexjhawk
requested changes
Sep 30, 2024
...com/hms_networks/americas/sc/ignition/comm/requests/m2w/M2WebEwonUpdateTagValuesRequest.java
Outdated
Show resolved
Hide resolved
...com/hms_networks/americas/sc/ignition/comm/requests/m2w/M2WebEwonUpdateTagValuesRequest.java
Outdated
Show resolved
Hide resolved
The Flexy UpdateTagForm request requires that boolean tag values are 1 or 0 and not true or false. This change updates the EwonUpdateTagValuesRequest class to convert boolean tag values to 1 or 0. Closes #155
The tag quality values differ between DataMailbox and the instant values from M2Web API. The former provides strings e.g., "good", "bad", and the later provides a bit map consisting of multiple flags. The connector maps DataMailbox responses to the instant value bitmaps. This commit corrects the mapping.
For DataMailbox responses, values are parsed to java Objects. The values 0 and 1 will be Doubles. The values True and False will be Booleans. Talk2M responses are parsed to Strings '1' and '0'. This addition will handle these possibilities.
Tag values from DataMailbox responses are parsed into Objects, which GSON makes Doubles. Tag values from Talk2M responses are parsed into Strings. This change allows for both.
|
@it-hms @alexjhawk are we able to get v2.0.1 merged so that we can test the Issue #154 fix? |
|
@alexjhawk , |
alexjhawk
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #154
closes #155