Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODPR-1663] - DEV: Registration Successful Changes. #144

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

georgievh
Copy link
Contributor

@georgievh georgievh commented Nov 6, 2024

Description

Please include a brief summary of the change you've made and the issue that it fixes.

Add a link to the relevant story in Jira
ODPR-1663

Checklist PR Raiser

Before creating PR
  • Have you run the tests?
  • Have you run the journey tests? (where applicable)
  • Have you addressed warnings where appropriate?
  • Have you rebased against the current version of main?
  • Have you checked code coverage isn’t lower than previously?
  • Have you checked to ensure all dependencies are up-to-date?
After PRs been raised
  • Have you checked the PR Builder passes?

Checklist PR Reviewer

Before Reviewing
  • Have you pulled the branch down?
  • Have you assigned yourself to the PR?
  • Have you moved the task to “in review” on JIRA?
  • Have you checked to ensure all dependencies are up-to-date?
  • Have you checked to ensure branch has been rebased against the current version of main?
Whilst Reviewing
  • Have you run the tests?
  • Have you run the journey tests?
  • Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?
After Reviewing
  • Have you checked for merge conflicts or any changes in the current main that may affect the current pull request?
    i.e. does it need another rebase?
  • Have you checked to make sure there are no builds in the pipeline before you merge?
  • Have you moved the task to “in pipeline” on Jira?

registrationConfirmation.organisation.p3 = To send a submission, you must add your business as a platform operator.
registrationConfirmation.h2.2 = Do you want to add a platform operator now?
registrationConfirmation.p4 = You can add a platform operator at any time.
registrationConfirmation.p2 = Make a note of your digital platform reporting user ID. We have sent a confirmation email to {0}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a full stop straight after the email address ?

Copy link
Contributor Author

@georgievh georgievh Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not changed that. This is how it was before. I only changed the key. So Yes, I think there should be

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should be using components for paragraphs, headers etc.
However this would require a considerable refactor, so happy to go with what we currently have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is how the project was started and same style is used on all pages.

@georgievh georgievh merged commit 677b063 into main Nov 12, 2024
1 check passed
@georgievh georgievh deleted the ODPR-1663 branch November 12, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants