Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMCA-4882] Bugfix: Fixing double headings #146

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

wg-hmrc
Copy link
Contributor

@wg-hmrc wg-hmrc commented Sep 20, 2024

No description provided.

@platops-pr-bot
Copy link

  • Config key metrics.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key microservice.metrics.graphite.enabled can be removed from conf/application.conf. This is already provided by Bootstrap
  • Config key auditing.enabled can be removed from conf/application.conf. This is already provided by Bootstrap

@tyagikumarvineet
Copy link
Contributor

Please fix the below scalastyle warnings

[warn] /Users/vineet.tyagi/hmrc/codebase/customs-cash-account-frontend/test/viewmodels/CashAccountV2ViewModelSpec.scala:22: File line length exceeds 160 characters
[warn] /Users/vineet.tyagi/hmrc/codebase/customs-cash-account-frontend/test/views/CashAccountTransactionsNotAvailableSpec.scala:67:0: Whitespace at end of line

@AdamCoops
Copy link
Contributor

no issues from, will approve once scalastyles are resolved.

@AdamCoops
Copy link
Contributor

You have a few broken tests

[info] *** 7 TESTS FAILED ***
[error] Failed tests:
[error] views.CashAccountTransactionsNotAvailableSpec
[error] controllers.CashAccountV2ControllerSpec
[error] views.CashAccountNoTransactionsWithBalanceSpec
[error] controllers.CashAccountControllerSpec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants