RWA-2607 Handle null and ServiceBusException #582
Conversation
| log.info("CCD Case Event message with id '{}' handled successfully", messageId); | ||
| } catch (Exception ex) { | ||
| log.error( | ||
| "Error processing CCD Case Event message with id '{}' - " |
There was a problem hiding this comment.
thoughts on adding sampling for this exception? as well? if it's all the same do we need to log all of them to app insights? https://learn.microsoft.com/en-us/azure/azure-monitor/app/java-standalone-sampling-overrides#getting-started
There was a problem hiding this comment.
Yeah I think Rafal is going to follow up at looking into that. This is the first PR since we saw lots of NPEs.
There was a problem hiding this comment.
I am totally not sure where to find spec for "telemetryType": "exception". If you will see one please send over. Added sampling to applicationinsights.json. Please have a look.
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/azure/azure-monitor/app/data-model-complete#exception is the only thing I have found. But there is nothing there why request has "http.url" as a key in the examples. They just mention "url"
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RWA-2607
Change description
Handle null gracefully and log error message on ServiceBusException instead of the whole exception.
Does this PR introduce a breaking change? (check one with "x")