Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dtsstci 68 #565

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Dtsstci 68 #565

wants to merge 11 commits into from

Conversation

gmmagruder
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/DTSSTCI-68

Change description

  • Added aria label to delete link in upload documents for voice over
  • Imported upload-documents css so it will be used

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

{% set documentId = file.documentId%}
<a href="/upload-appeal-form?query=delete&docId={{documentId}}&documentType=tribunalform" class="govuk-link--no-visited-state float-right ">{{ delete }}</a>
<a href="/upload-appeal-form?query=delete&docId={{documentId}}&documentType=tribunalform" class="govuk-link--no-visited-state float-right " id="Delete{{ loop.index0 }}" aria-labelledby="Delete{{ loop.index0 }} Document{{ loop.index0 }}">{{ delete }}</a>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for these could have been made in assets/js/upload-manager/updateFileList.ts but it was not being used. I think it used for uploading to /document-manager (DOCUMENT_UPLOAD_URL) but the code doesn't currently do that at any point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will include it in my ticket for future improvements

tomxelliott
tomxelliott previously approved these changes Nov 28, 2023
@hmcts-jenkins-j-to-z
Copy link
Contributor

Plan Result

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • module.sptribs-frontend-session-storage.azurerm_redis_cache.redis
Change Result (Click me)
  # module.sptribs-frontend-session-storage.azurerm_redis_cache.redis will be updated in-place
  ~ resource "azurerm_redis_cache" "redis" {
        id                            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/sptribs-cache-aat/providers/Microsoft.Cache/redis/sptribs-aat"
        name                          = "sptribs-aat"
        tags                          = {
            "application"         = "special-tribunals"
            "autoShutdown"        = "true"
            "builtFrom"           = "https://github.com/HMCTS/sptribs-frontend.git"
            "businessArea"        = "CFT"
            "contactSlackChannel" = "#special-tribunals-dev-channel"
            "environment"         = "staging"
            "managedBy"           = "Special Tribunals"
        }
        # (21 unchanged attributes hidden)

      ~ redis_configuration {
          ~ maxfragmentationmemory_reserved = 125 -> 642
          ~ maxmemory_delta                 = 125 -> 642
          ~ maxmemory_reserved              = 125 -> 642
            # (7 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants