Fix caselist loading when not running on ES (#821)

* Fix proxying of calls to /aggregated/.../cases

This fixes loading of the case list when not running on Elastic Search.

This change avoids returning jurisdicitonal details instead of case
data.

* whitespace fix

* add additional spec for non jurisdiction url

* fix typo

api/amendedJurisdictions/index.spec.ts

@@ -61,12 +61,36 @@ describe('Amended Jurisdiction', () => {
     sandbox.restore()
   })
 
-  it('should send PROBATE array',  () => {
+  it('should filter jurisdictions for the jurisdictions endpoint',  () => {
+    const data = [
+      {
+        id: 'PROBATE',
+      },
+      {
+        id: 'RANDOM',
+      },
+    ]
+    req.url = 'aggregated/caseworkers/:uid/jurisdictions?access=read'
+    const response = amendedJurisdictions.getJurisdictions(proxyRes, req, res, data)
+    // Unknown jurisdiction should be filtered
     const expected = [
-        {
-            id: 'PROBATE',
-        },
+      {
+        id: 'PROBATE',
+      },
+    ]
+    expect(response).to.eql(expected)
+  })
+
+  it('should not filter jurisdictions for non-jurisdictions endpoint',  () => {
+    const expected = [
+      {
+        id: 'PROBATE',
+      },
+      {
+        id: 'RANDOM',
+      },
     ]
+    req.url = '/aggregated/some/other/url'
 
     const response = amendedJurisdictions.getJurisdictions(proxyRes, req, res, expected)
     expect(response).to.eql(expected)

api/amendedJurisdictions/index.ts

@@ -1,12 +1,15 @@
 import {getConfigValue} from '../configuration'
 import { JURISDICTIONS } from '../configuration/references'
 
+const jurisdictions = /aggregated\/.+jurisdictions\?/
+
 /**
  * Manually filtering returned jurisdictions
  * to make available jurisdiction in filters array only
  */
 export const getJurisdictions = (proxyRes, req, res, data: any[]) => {
-    if (!Array.isArray(data)) {
+    if (!Array.isArray(data)
+        || !jurisdictions.test(req.url)) {
         return data
     }
     const filters = getConfigValue(JURISDICTIONS)
@@ -15,8 +18,10 @@ export const getJurisdictions = (proxyRes, req, res, data: any[]) => {
 }
 
 export const checkCachedJurisdictions = (proxyReq, req, res) => {
-    if (req.session.jurisdictions) {
-        res.send(req.session.jurisdictions)
-        proxyReq.end()
+    if (jurisdictions.test(req.url)) {
+        if (req.session.jurisdictions) {
+            res.send(req.session.jurisdictions)
+            proxyReq.end()
+        }
     }
 }