-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTSPB-4361: 'Exec not accounted for' journeys #2335
Draft
jamiealbertelli
wants to merge
47
commits into
master
Choose a base branch
from
DTSPB-4361-exec-not-accounted-for-journeys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
273da12
DTSPB-4411: Update probate journey to contain new executor check will…
jamiealbertelli 0d75959
DTSPB-4411: Add new preliminary files for new Exec check will page
jamiealbertelli 058a6db
DTSPB-4411: Complete FE text and bullets
jamiealbertelli d86a363
Merge branch 'master' into DTSPB-4411-back-button-spike
jamiealbertelli 11bd321
DTSPB-4411: 'Save and Continue -> Continue' button change
jamiealbertelli da457b8
DTSPB-4411: Fix test to expect new page
jamiealbertelli b1c1a24
DTSPB-4411: Adjust probate journey according to new multi exec changes
jamiealbertelli 919cf16
DTSPB-4411: Conditionally render question content depending on number…
jamiealbertelli 490d6dc
DTSPB-4411: Update new content
jamiealbertelli cbd8449
DTSPB-4411: Rename URL and add nextStepOptions multi exec logic
jamiealbertelli 4f6a640
DTSPB-4411: Update schema for radio buttons
jamiealbertelli ac34357
DTSPB-4411: Add preliminary html for updated executor named page
jamiealbertelli d291291
DTSPB-4411: Add preliminary html add exec name page
jamiealbertelli 0f65a5b
DTSPB-4411: Update summary page to reflect changed URL and to continu…
jamiealbertelli 6315ecf
Merge branch 'master' into DTSPB-4411-back-button-spike
jamiealbertelli b5bc19a
DTSPB-4411: Fix journey order to allow back button to work correctly
jamiealbertelli 1f0076f
DTSPB-4411: Determine next step depending on answer and journey type
jamiealbertelli f582bb9
DTSPB-4411: Change schema to pass through a named exec
jamiealbertelli b2dd572
DTSPB-4411: Add some preliminary code to display multiple execs
jamiealbertelli c66d456
DTSPB-4411: Change schema to pass through a named exec
jamiealbertelli ac5abab
DTSPB-4411: Merge
jamiealbertelli 6943b78
Merge branch 'master' into DTSPB-4361-exec-not-accounted-for-journeys
jamiealbertelli 110f8eb
Merge branch 'master' into DTSPB-4361-exec-not-accounted-for-journeys
IswaryaPepakayala 93b5de1
DTSPB-4361 Added Executors to the list and some content changes
IswaryaPepakayala 16b9922
DTSPB-4361 Content changes
IswaryaPepakayala 820090c
DTSPB-4361: Delete dealingwithestate pages as the functionality is be…
jamiealbertelli b5d13ba
DTSPB-4361: Delete dealingwithestate page
jamiealbertelli bdbf813
DTSPB-4361: Adjust journey now dealingwithestate and applying pages l…
jamiealbertelli 216d727
DTSPB-4361: Add preliminary content for new /applying page
jamiealbertelli 3cd907c
DTSPB-4361: Modify schema so checkboxes can function
jamiealbertelli 2002ca9
DTSPB-4361: Modify template to radio or checkbox is conditionally dis…
jamiealbertelli 3c78e26
DTSPB-4361: Update index with dealingwithestate checkbox logic whilst…
jamiealbertelli d4c4cd0
DTSPB-4361: Merge
jamiealbertelli a8b181b
DTSPB-4361 Content changes and loop changes for pages after alias page
IswaryaPepakayala 89dbd34
DTSPB-4361 Welsh content changes and loop/error changes for executor …
IswaryaPepakayala 7d18173
DTSPB-4361 Remove link changes
IswaryaPepakayala cfd45cb
DTSPB-4361 Dynamic text in error message changes
IswaryaPepakayala 27c7830
DTSPB-4361: Add dynamic title
jamiealbertelli 52a8a15
DTSPB-4361: Update Welsh
jamiealbertelli 8a4df46
DTSPB-4361: Add dynamic title
jamiealbertelli 7a38ace
DTSPB-4361: Fix formatting
jamiealbertelli 3781925
DTSPB-4361 Fix unit test
IswaryaPepakayala 57a57f1
DTSPB-4361: Prune data so forms are not already populated
jamiealbertelli f2ab8b2
DTSPB-4361: Bring correct commit in
jamiealbertelli 7a40d6a
DTSPB-4361: Add dynamic error display functionality depending on will…
jamiealbertelli cda8e5a
Merge branch 'master' into DTSPB-4361-exec-not-accounted-for-journeys
MarcusHMCTS 1d36910
Merge remote-tracking branch 'origin/DTSPB-4361-exec-not-accounted-fo…
MarcusHMCTS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,19 @@ | ||
{ | ||
"title": "A oes gan unrhyw un o’r ysgutorion hyn enw gwahanol nawr i beth sydd yn yr ewyllys neu unrhyw godisiliau", | ||
"question": "A oes gan unrhyw un o’r ysgutorion hyn enw gwahanol nawr i beth sydd yn yr ewyllys neu unrhyw godisiliau?", | ||
"optionYes": "Oes", | ||
"optionNo": "Nac oes", | ||
"question": "Ydy’r enw ‘{executorWillName}’ yn wahanol i sut mae’n ymddangos ar eu pasbort neu ffurf arall o brawf adnabod?", | ||
"paragraph1": "Dylech wneud yn siŵr mai hwn yw’r un math o ddull adnabod y bydd {executorWillName} yn ei ddefnyddio pan fyddant yn delio ag ystad {deceasedName}.", | ||
"paragraph2": "Gallai eu henw fod yn wahanol oherwydd:", | ||
"listItem1": "gwnaethant newid eu henw ar ôl gwneud yr ewyllys", | ||
"listItem2": "ni chafodd rhan o’u henw ei gynnwys yn yr ewyllys", | ||
"listItem3": "roedd camgymeriad sillafu yn yr ewyllys", | ||
"listItem4": "maent hefyd yn cael eu hadnabod fel enw gwahanol", | ||
"paragraph3": "Os oes gwahaniaeth, byddwch yn gallu dweud wrthym pam yn ddiweddarach.", | ||
"optionYes": "Yes", | ||
"optionNo": "No", | ||
|
||
"errors": { | ||
"alias": { | ||
"required": "Dewiswch ‘oes’ os oes gan unrhyw un o’r ysgutorion enw gwahanol i beth sydd yn yr ewyllys neu unrhyw godisiliau" | ||
"required": "Dewiswch do ydy os ydy enw {executorName} yn wahanol i’r ffordd y mae’n ymddangos ar eu pasbort neu ffurf arall o brawf adnabod" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
{ | ||
"title": "A yw’r holl ysgutorion dal yn fyw", | ||
"question": "A yw’r holl ysgutorion yn fyw?", | ||
"oneOtherQuestion": "A yw {executorName} wedi marw ers i'r ewyllys gael ei llofnodi?", | ||
"multipleExecutorQuestion": "A oes unrhyw un o’r ysgutorion wedi marw ers llofnodi’r ewyllys?", | ||
"optionYes": "Ydyn", | ||
"optionNo": "Nac ydyn", | ||
|
||
"errors": { | ||
"allalive": { | ||
"required": "Atebwch ‘ydyn’ os yw’r holl ysgutorion dal yn fyw" | ||
"singleExecutorRequired": "Atebwch ‘ydyn’ os yw’r holl ysgutorion dal yn fyw", | ||
"multipleExecutorRequired": "Dewiswch oes os oes unrhyw un o’r ysgutorion wedi marw ers llofnodi’r ewyllys" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"title": "Gwiriwch yr ewyllys wreiddiol", | ||
"titleWithCodicil": "Gwiriwch yr ewyllys wreiddiol a’r codisiliau nawr", | ||
"paragraph1": "Mae angen i ni wybod am bawb a enwir gan {deceasedName} fel ysgutor yn yr ewyllys.", | ||
"paragraph1WithCodicil": "Mae angen i ni wybod am bawb a enwir gan {deceasedName} fel ysgutor yn yr ewyllys ac unrhyw godisiliau.", | ||
"paragraph2": "Mae hyn yn cynnwys unrhyw un sydd:", | ||
"bullet1": "wedi marw ers llofnodi’r ewyllys – hyd yn oed os yw’r ewyllys yn enwi ysgutor dirprwyol", | ||
"bullet2": "ddim eisiau gwneud cais am brofiant ar hyn o bryd", | ||
"bullet3": "yn ildio eu hawl i wneud cais yn barhaol" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 10 additions & 6 deletions
16
app/resources/cy/translation/executors/currentnamereason.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletions
16
app/resources/cy/translation/executors/dealingwithestate.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"title": "Ysgutorion a enwir yn yr ewyllys", | ||
"titleWithCodicil": "Ysgutorion a enwir yn yr ewyllys ac unrhyw godisiliau", | ||
"question": "A oes unrhyw ysgutorion eraill a enwir?", | ||
"hintText": "Sicrhewch eich bod yn cynnwys pob ysgutor a enwir yn yr ewyllys, gan gynnwys unrhyw un sydd:", | ||
"hintTextWithCodicil": "Sicrhewch eich bod yn cynnwys pob ysgutor a enwir yn yr ewyllys ac unrhyw godisiliau, gan gynnwys unrhyw un sydd:", | ||
"executorsDied": "wedi marw", | ||
"executorsNotApplying": "ddim yn gwneud cais am brofiant", | ||
"executorsGivenUpRight": "wedi ildio eu hawl i wneud cais", | ||
"executorsNamed": "Nifer yr ysgutorion", | ||
"applicantExecutor" : "Ysgutor (chi)", | ||
"furtherExecutor": "Ysgutor", | ||
"executorTellUsMore": "Byddwch yn gallu dweud mwy wrthym am bob ysgutor yn ddiweddarach.", | ||
"optionYes": "Oes", | ||
"optionNo": "Nac oes", | ||
"removeAction": "Dileu", | ||
|
||
"errors": { | ||
"executorsNamed": { | ||
"required": "Dewiswch ‘oes’ os oes mwy o ysgutorion wedi’u henwi yn yr ewyllys", | ||
"requiredCodicils": "NOT CORRECT WELSH - NEED CODICILS Dewiswch ‘oes’ os oes mwy o ysgutorion wedi’u henwi yn yr ewyllys" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,12 @@ | ||
{ | ||
"title": "Ysgutor wedi’i hysbysu", | ||
"question": "Ydych chi wedi hysbysu {executorName} yn ysgrifenedig eich bod yn gwneud cais?", | ||
"question": "Ydych chi wedi hysbysu {executorName} yn ysgrifenedig eich bod yn gwneud y cais hwn?", | ||
"optionYes": "Do", | ||
"optionNo": "Naddo", | ||
"informInWriting": "Mae’n rhaid ichi hysbysu’r ysgutor yn ysgrifenedig eich bod yn gwneud cais am brofiant", | ||
|
||
"errors": { | ||
"executorNotified": { | ||
"required": "Atebwch ‘do’ os ydych wedi hysbysu’r ysgutor yn ysgrifenedig " | ||
"required": "Dewiswch do os ydych wedi hysbysu {executorName} yn ysgrifenedig" | ||
} | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,14 @@ | ||
{ | ||
"title": "Rheswm dros beidio â gwneud cais am brofiant", | ||
"question": "Pam nad yw {executorFullName} yn gwneud cais am brofiant?", | ||
"optionPowerReserved": "Nid yw’r ysgutor hwn eisiau gwneud cais nawr, ond efallai y bydd yn dymuno gwneud hynny yn y dyfodol (gelwir hyn hefyd yn cadw’r hawl)", | ||
"optionRenunciated": "Nid yw’r ysgutor hwn eisiau gwneud cais nawr, ac mae’n rhoi fyny yr hawl i wneud hynny yn y dyfodol (gelwir hyn hefyd yn ymwrthod, a bydd angen i’r ysgutor lenwi ffurflen)", | ||
"optionRenunciatedHint": "Llenwch naill ai <a href=\"{applicationFormPA15}\" class=\"govuk-link\" target=\"_blank\" rel=\"external noopener\" aria-label=\"ffurflen PA15 neu PA16 (agor mewn ffenestr newydd)\">ffurflen PA15 neu PA16 (agor mewn ffenestr newydd)</a> os ydych eisiau ildio eich cyfrifoldeb cyfreithiol a’ch swyddogaeth yn barhaol (a elwir hefyd yn ‘ymwrthod’) i wneud cais am brofiant i reoli ystad rhywun a fu farw fel un ai:", | ||
"optionRenunciatedHintBullet1": "ysgutor a enwir yn ei ewyllys, neu", | ||
"optionRenunciatedHintBullet2": "priod neu bartner sifil sy’n gweithredu fel gweinyddwr.", | ||
"optionPowerReserved": "Mae {executorFullName} yn cadw’r hawl i wneud cais yn ddiweddarach (a elwir yn ‘cadw’r hawl’)", | ||
"optionPowerReservedHint": "Bydd angen i chi roi gwybod iddynt yn ysgrifenedig eich bod yn gwneud y cais hwn.", | ||
"optionRenunciated": "Mae {executorFullName} yn ildio eu hawl i wneud cais yn barhaol (a elwir hefyd yn ‘ymwrthod’)", | ||
"optionRenunciatedHint": "Bydd angen i chi anfon eu ymwrthod wedi’i llenwi atom <a href=\"{applicationFormPA15}\" class=\"govuk-link\" target=\"_blank\" rel=\"external noopener\" aria-label=\"ffurflen PA15 (yn agor mewn tab newydd)\">ffurflen PA15 (yn agor mewn tab newydd)</a> ynghyd â’ch dogfennau eraill.", | ||
|
||
"errors": { | ||
"notApplyingReason": { | ||
"required": "Dewiswch y rheswm pam nad yw’r ysgutor yn gwneud cais " | ||
"required": "Dewiswch reswm dros pam nad yw {executorName} yn gwneud cais" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
{ | ||
"title": "Pryd farwodd yr ysgutor?", | ||
"question": "A wnaeth {executorFullName} farw cyn yr unigolyn sydd wedi marw?", | ||
"question": "A wnaeth {executorFullName} farw cyn {deceasedName}?", | ||
"optionYes": "Do", | ||
"optionNo": "Naddo", | ||
"executorFullName": "", | ||
|
||
"errors": { | ||
"diedbefore": { | ||
"required": "Atebwch ‘do’ os farwodd yr ysgutor cyn yr unigolyn sydd wedi marw" | ||
"required": "Dewiswch do os wnaeth {executorName} farw cyn {deceasedName}" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"title": "Ysgutorion a enwir yn yr ewyllys", | ||
"titleWithCodicil": "Ysgutorion a enwir yn yr ewyllys ac unrhyw godisiliau", | ||
"question": "A oes unrhyw ysgutorion eraill a enwir?", | ||
"hintText": "Sicrhewch eich bod yn cynnwys pob ysgutor a enwir yn yr ewyllys, gan gynnwys unrhyw un sydd:", | ||
"hintTextWithCodicil": "Sicrhewch eich bod yn cynnwys pob ysgutor a enwir yn yr ewyllys ac unrhyw godisiliau, gan gynnwys unrhyw un sydd:", | ||
"executorsDied": "wedi marw", | ||
"executorsNotApplying": "ddim yn gwneud cais am brofiant", | ||
"executorsGivenUpRight": "wedi ildio eu hawl i wneud cais", | ||
"executorsNamed": "Nifer yr ysgutorion", | ||
"applicantExecutor" : "Ysgutor (chi)", | ||
"furtherExecutor": "Ysgutor", | ||
"executorTellUsMore": "Byddwch yn gallu dweud mwy wrthym am bob ysgutor yn ddiweddarach.", | ||
"optionYes": "Oes", | ||
"optionNo": "Nac oes", | ||
"removeAction": "Dileu", | ||
|
||
"errors": { | ||
"executorsNamed": { | ||
"required": "Nodwch nifer yr ysgutorion" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to find correct Welsh