Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dtspb 4222 order extra copies drop off fix #2320

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
9828f4c
DTSPB-4222 Order extra copies drop off fix
FeliTam Nov 27, 2024
cb66175
DTSPB-4222 update lists.html
FeliTam Nov 28, 2024
239a3cd
DTSPB-4231 Styling changes
IswaryaPepakayala Nov 28, 2024
6f0292e
DTSPB-4222 fix next url in copies summary
FeliTam Nov 28, 2024
8af2977
DTSPB-4222 reduce section-number width
FeliTam Nov 29, 2024
c4b3d73
upgrade govuk-frontend to v5
FeliTam Nov 29, 2024
18566b8
update css ver
FeliTam Nov 29, 2024
0fb04de
fix ally and cve warning
FeliTam Nov 29, 2024
7d74087
update dashboard status text
FeliTam Nov 29, 2024
d744408
DTSPB-4231 Styling changes
IswaryaPepakayala Dec 4, 2024
3ac7765
DTSPB-4231 Styling changes and condition change for banner
IswaryaPepakayala Dec 4, 2024
9e284e2
DTSPB-4231 fix test
IswaryaPepakayala Dec 4, 2024
eca4401
DTSPB-4231 revert yarn.lock
IswaryaPepakayala Dec 4, 2024
9710d06
DTSPB-4231 yarn.lock
IswaryaPepakayala Dec 4, 2024
6f69979
DTSPB-4231 styling changes
IswaryaPepakayala Dec 4, 2024
dd4ef2d
change the hr position
FeliTam Dec 5, 2024
cf77a64
DTSPB-4231 Fix styling for multiple executor journey and e2e fix
IswaryaPepakayala Dec 6, 2024
4b8a08d
DTSPB-4231 suppress vunerability
IswaryaPepakayala Dec 6, 2024
6421fb0
fix task list Check your answers link
FeliTam Dec 6, 2024
db3185d
yarn install
FeliTam Dec 6, 2024
34b878b
Merge branch 'master' into DTSPB-4222_order-extra-copies-drop-off-fix
FeliTam Dec 9, 2024
0a3a8ca
DTSPB-4222 fix missing welsh translation
FeliTam Dec 9, 2024
c0bf16b
fix cve suppression
FeliTam Dec 9, 2024
805c0f5
DTSPB-4222 add back link to payment breakdown page
FeliTam Dec 9, 2024
1324c30
DTSPB-4222 update css file ver
FeliTam Dec 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ exports.init = function (isA11yTest = false, a11yTestSession = {}, ftValue) {
const njkEnv = nunjucks.configure([
'app/steps',
'app/views',
'node_modules/govuk-frontend/'
'node_modules/govuk-frontend/dist'
], {
noCache: isDev,
express: app
Expand Down Expand Up @@ -191,15 +191,15 @@ exports.init = function (isA11yTest = false, a11yTestSession = {}, ftValue) {
app.use('/public/stylesheets', express.static(`${__dirname}/public/stylesheets`, caching));
app.use('/public/images', express.static(`${__dirname}/app/assets/images`, caching));
app.use('/public/locales', express.static(`${__dirname}/app/assets/locales`, caching));
app.use('/public/javascripts/govuk-frontend', express.static(`${__dirname}/node_modules/govuk-frontend`, caching));
app.use('/public/javascripts/govuk-frontend', express.static(`${__dirname}/node_modules/govuk-frontend/dist`, caching));
app.use('/public/javascripts/jquery', express.static(`${__dirname}/node_modules/jquery/dist`, caching));
app.use('/public/javascripts', express.static(`${__dirname}/app/assets/javascripts`, caching));
app.use('/public/pdf', express.static(`${__dirname}/app/assets/pdf`));
app.use('/assets', express.static(`${__dirname}/node_modules/govuk-frontend/govuk/assets`, caching));
app.use('/assets', express.static(`${__dirname}/node_modules/govuk-frontend/dist/govuk/assets`, caching));
app.use('/assets/locale', express.static(`${__dirname}/app/assets/locales/avaya-webchat`, caching));

// Elements refers to icon folder instead of images folder
app.use(favicon(path.join(__dirname, 'node_modules', 'govuk-frontend', 'govuk', 'assets', 'images', 'favicon.ico')));
app.use(favicon(path.join(__dirname, 'node_modules', 'govuk-frontend', 'dist', 'govuk', 'assets', 'images', 'favicon.ico')));

// Support for parsing data in POSTs
app.use(bodyParser.json());
Expand Down
61 changes: 31 additions & 30 deletions app/assets/sass/application-ie8.scss
Original file line number Diff line number Diff line change
@@ -1,36 +1,37 @@
$path: "/public/images/";

// Import GOV.UK Frontend
@import "node_modules/govuk-frontend/govuk/base";
@import "node_modules/govuk-frontend/govuk/settings/all";
@import "node_modules/govuk-frontend/govuk/core/all";
@import "node_modules/govuk-frontend/govuk/objects/all";
@import "node_modules/govuk-frontend/govuk/components/button/button";
@import "node_modules/govuk-frontend/govuk/components/checkboxes/checkboxes";
@import "node_modules/govuk-frontend/govuk/components/cookie-banner/cookie-banner";
@import "node_modules/govuk-frontend/govuk/components/date-input/date-input";
@import "node_modules/govuk-frontend/govuk/components/details/details";
@import "node_modules/govuk-frontend/govuk/components/error-message/error-message";
@import "node_modules/govuk-frontend/govuk/components/error-summary/error-summary";
@import "node_modules/govuk-frontend/govuk/components/fieldset/fieldset";
@import "node_modules/govuk-frontend/govuk/components/footer/footer";
@import "node_modules/govuk-frontend/govuk/components/header/header";
@import "node_modules/govuk-frontend/govuk/components/hint/hint";
@import "node_modules/govuk-frontend/govuk/components/input/input";
@import "node_modules/govuk-frontend/govuk/components/inset-text/inset-text";
@import "node_modules/govuk-frontend/govuk/components/panel/panel";
@import "node_modules/govuk-frontend/govuk/components/phase-banner/phase-banner";
@import "node_modules/govuk-frontend/govuk/components/radios/radios";
@import "node_modules/govuk-frontend/govuk/components/select/select";
@import "node_modules/govuk-frontend/govuk/components/skip-link/skip-link";
@import "node_modules/govuk-frontend/govuk/components/summary-list/summary-list";
@import "node_modules/govuk-frontend/govuk/components/table/table";
@import "node_modules/govuk-frontend/govuk/components/tag/tag";
@import "node_modules/govuk-frontend/govuk/components/textarea/textarea";
@import "node_modules/govuk-frontend/govuk/components/warning-text/warning-text";
@import "node_modules/govuk-frontend/govuk/utilities/all";
@import "node_modules/govuk-frontend/govuk/overrides/all";
@import "node_modules/govuk-frontend/govuk/components/notification-banner/notification-banner";
@import "node_modules/govuk-frontend/dist/govuk/base";
@import "node_modules/govuk-frontend/dist/govuk/settings/all";
@import "node_modules/govuk-frontend/dist/govuk/core/all";
@import "node_modules/govuk-frontend/dist/govuk/objects/all";
@import "node_modules/govuk-frontend/dist/govuk/components/button/button";
@import "node_modules/govuk-frontend/dist/govuk/components/checkboxes/checkboxes";
@import "node_modules/govuk-frontend/dist/govuk/components/cookie-banner/cookie-banner";
@import "node_modules/govuk-frontend/dist/govuk/components/date-input/date-input";
@import "node_modules/govuk-frontend/dist/govuk/components/details/details";
@import "node_modules/govuk-frontend/dist/govuk/components/error-message/error-message";
@import "node_modules/govuk-frontend/dist/govuk/components/error-summary/error-summary";
@import "node_modules/govuk-frontend/dist/govuk/components/fieldset/fieldset";
@import "node_modules/govuk-frontend/dist/govuk/components/footer/footer";
@import "node_modules/govuk-frontend/dist/govuk/components/header/header";
@import "node_modules/govuk-frontend/dist/govuk/components/hint/hint";
@import "node_modules/govuk-frontend/dist/govuk/components/input/input";
@import "node_modules/govuk-frontend/dist/govuk/components/inset-text/inset-text";
@import "node_modules/govuk-frontend/dist/govuk/components/panel/panel";
@import "node_modules/govuk-frontend/dist/govuk/components/phase-banner/phase-banner";
@import "node_modules/govuk-frontend/dist/govuk/components/radios/radios";
@import "node_modules/govuk-frontend/dist/govuk/components/select/select";
@import "node_modules/govuk-frontend/dist/govuk/components/skip-link/skip-link";
@import "node_modules/govuk-frontend/dist/govuk/components/summary-list/summary-list";
@import "node_modules/govuk-frontend/dist/govuk/components/table/table";
@import "node_modules/govuk-frontend/dist/govuk/components/tag/tag";
@import "node_modules/govuk-frontend/dist/govuk/components/textarea/textarea";
@import "node_modules/govuk-frontend/dist/govuk/components/warning-text/warning-text";
@import "node_modules/govuk-frontend/dist/govuk/utilities/all";
@import "node_modules/govuk-frontend/dist/govuk/overrides/all";
@import "node_modules/govuk-frontend/dist/govuk/components/notification-banner/notification-banner";
@import "node_modules/govuk-frontend/dist/govuk/components/task-list/task-list";

@import "patterns/phase-banner";
@import "patterns/header";
Expand Down
63 changes: 32 additions & 31 deletions app/assets/sass/application.scss
Original file line number Diff line number Diff line change
@@ -1,37 +1,38 @@
$path: "/public/images/";

// Import GOV.UK Frontend
@import "node_modules/govuk-frontend/govuk/base";
@import "node_modules/govuk-frontend/govuk/settings/all";
@import "node_modules/govuk-frontend/govuk/core/all";
@import "node_modules/govuk-frontend/govuk/objects/all";
@import "node_modules/govuk-frontend/govuk/components/back-link/back-link";
@import "node_modules/govuk-frontend/govuk/components/button/button";
@import "node_modules/govuk-frontend/govuk/components/checkboxes/checkboxes";
@import "node_modules/govuk-frontend/govuk/components/cookie-banner/cookie-banner";
@import "node_modules/govuk-frontend/govuk/components/date-input/date-input";
@import "node_modules/govuk-frontend/govuk/components/details/details";
@import "node_modules/govuk-frontend/govuk/components/error-message/error-message";
@import "node_modules/govuk-frontend/govuk/components/error-summary/error-summary";
@import "node_modules/govuk-frontend/govuk/components/fieldset/fieldset";
@import "node_modules/govuk-frontend/govuk/components/footer/footer";
@import "node_modules/govuk-frontend/govuk/components/header/header";
@import "node_modules/govuk-frontend/govuk/components/hint/hint";
@import "node_modules/govuk-frontend/govuk/components/input/input";
@import "node_modules/govuk-frontend/govuk/components/inset-text/inset-text";
@import "node_modules/govuk-frontend/govuk/components/panel/panel";
@import "node_modules/govuk-frontend/govuk/components/phase-banner/phase-banner";
@import "node_modules/govuk-frontend/govuk/components/radios/radios";
@import "node_modules/govuk-frontend/govuk/components/select/select";
@import "node_modules/govuk-frontend/govuk/components/skip-link/skip-link";
@import "node_modules/govuk-frontend/govuk/components/summary-list/summary-list";
@import "node_modules/govuk-frontend/govuk/components/table/table";
@import "node_modules/govuk-frontend/govuk/components/tag/tag";
@import "node_modules/govuk-frontend/govuk/components/textarea/textarea";
@import "node_modules/govuk-frontend/govuk/components/warning-text/warning-text";
@import "node_modules/govuk-frontend/govuk/utilities/all";
@import "node_modules/govuk-frontend/govuk/overrides/all";
@import "node_modules/govuk-frontend/govuk/components/notification-banner/notification-banner";
@import "node_modules/govuk-frontend/dist/govuk/base";
@import "node_modules/govuk-frontend/dist/govuk/settings/all";
@import "node_modules/govuk-frontend/dist/govuk/core/all";
@import "node_modules/govuk-frontend/dist/govuk/objects/all";
@import "node_modules/govuk-frontend/dist/govuk/components/back-link/back-link";
@import "node_modules/govuk-frontend/dist/govuk/components/button/button";
@import "node_modules/govuk-frontend/dist/govuk/components/checkboxes/checkboxes";
@import "node_modules/govuk-frontend/dist/govuk/components/cookie-banner/cookie-banner";
@import "node_modules/govuk-frontend/dist/govuk/components/date-input/date-input";
@import "node_modules/govuk-frontend/dist/govuk/components/details/details";
@import "node_modules/govuk-frontend/dist/govuk/components/error-message/error-message";
@import "node_modules/govuk-frontend/dist/govuk/components/error-summary/error-summary";
@import "node_modules/govuk-frontend/dist/govuk/components/fieldset/fieldset";
@import "node_modules/govuk-frontend/dist/govuk/components/footer/footer";
@import "node_modules/govuk-frontend/dist/govuk/components/header/header";
@import "node_modules/govuk-frontend/dist/govuk/components/hint/hint";
@import "node_modules/govuk-frontend/dist/govuk/components/input/input";
@import "node_modules/govuk-frontend/dist/govuk/components/inset-text/inset-text";
@import "node_modules/govuk-frontend/dist/govuk/components/panel/panel";
@import "node_modules/govuk-frontend/dist/govuk/components/phase-banner/phase-banner";
@import "node_modules/govuk-frontend/dist/govuk/components/radios/radios";
@import "node_modules/govuk-frontend/dist/govuk/components/select/select";
@import "node_modules/govuk-frontend/dist/govuk/components/skip-link/skip-link";
@import "node_modules/govuk-frontend/dist/govuk/components/summary-list/summary-list";
@import "node_modules/govuk-frontend/dist/govuk/components/table/table";
@import "node_modules/govuk-frontend/dist/govuk/components/tag/tag";
@import "node_modules/govuk-frontend/dist/govuk/components/textarea/textarea";
@import "node_modules/govuk-frontend/dist/govuk/components/warning-text/warning-text";
@import "node_modules/govuk-frontend/dist/govuk/utilities/all";
@import "node_modules/govuk-frontend/dist/govuk/overrides/all";
@import "node_modules/govuk-frontend/dist/govuk/components/notification-banner/notification-banner";
@import "node_modules/govuk-frontend/dist/govuk/components/task-list/task-list";

@import "patterns/phase-banner";
@import "patterns/header";
Expand Down
6 changes: 3 additions & 3 deletions app/assets/sass/patterns/_task-list.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Task List
.task-item {
border-top: 1px solid govuk-colour("mid-grey");
line-height: 1.5;
padding: 20px 0 10px 0;
padding: 10px 0 10px 0;

&:last-child {
border-bottom: 1px solid govuk-colour("mid-grey");
Expand All @@ -57,12 +57,12 @@ Task List
}

.task-list-section-number {
width: govuk-spacing(5);
width: govuk-spacing(1);
padding-right: 0;
display: table-cell;

@include govuk-media-query($from: desktop) {
width: govuk-spacing(8);
width: govuk-spacing(2);
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/components/step-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ const getScrennersPreviousUrl = (ctx, req, res, steps, currentStepName) => {
};

const isNoBackLinkStepName = (stepName) => {
return stepName==='CitizensHub' || stepName==='PaymentBreakdown' || stepName==='PaymentStatus' ||
return stepName==='CitizensHub' || stepName==='PaymentStatus' ||
stepName==='ExecutorsAdditionalInvite' || stepName==='ThankYou' || stepName==='ExecutorsChangeMade' ||
stepName==='ExecutorsInvitesSent' || stepName==='ExecutorsUpdateInviteSent';
};
Expand Down
9 changes: 2 additions & 7 deletions app/journeys/intestacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,8 @@ const taskList = {
lastStep: 'TaskList',
summary: 'Summary'
},
CopiesTask: {
firstStep: 'CopiesStart',
lastStep: 'CopiesSummary',
summary: 'CopiesSummary'
},
PaymentTask: {
firstStep: 'PaymentBreakdown',
firstStep: 'CopiesStart',
lastStep: 'TaskList',
summary: 'Summary'
},
Expand Down Expand Up @@ -209,7 +204,7 @@ const stepList = {
otherwise: 'CopiesSummary'
},
CopiesOverseas: 'CopiesSummary',
CopiesSummary: 'TaskList',
CopiesSummary: 'PaymentBreakdown',
PaymentBreakdown: 'PaymentStatus',
PaymentStatus: 'TaskList',
Documents: 'ThankYou',
Expand Down
9 changes: 2 additions & 7 deletions app/journeys/probate.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,8 @@ const taskList = {
lastStep: 'TaskList',
summary: 'Summary'
},
CopiesTask: {
firstStep: 'CopiesStart',
lastStep: 'CopiesSummary',
summary: 'CopiesSummary'
},
PaymentTask: {
firstStep: 'PaymentBreakdown',
firstStep: 'CopiesStart',
lastStep: 'TaskList',
summary: 'Summary'
},
Expand Down Expand Up @@ -255,7 +250,7 @@ const stepList = {
otherwise: 'CopiesSummary'
},
CopiesOverseas: 'CopiesSummary',
CopiesSummary: 'TaskList',
CopiesSummary: 'PaymentBreakdown',
PaymentBreakdown: 'PaymentStatus',
PaymentStatus: 'TaskList',
AddressLookup: 'AddressLookup',
Expand Down
6 changes: 3 additions & 3 deletions app/resources/cy/translation/dashboard.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"tableHeaderActions": "Camau gweithredu",
"statusDraftProbate": "Nid yw'r enw wedi'i nodi eto",
"statusDraftIntestacy": "Nid yw'r enw wedi'i nodi eto",
"statusInProgress": "YN MYND RHAGDDO",
"statusSubmitted": "CYFLWYNWYD",
"statusGrantIssued": "GRANT WEDI'I GYHOEDDI",
"statusInProgress": "Yn mynd rhagddo",
"statusSubmitted": "Cyflwynwyd",
"statusGrantIssued": "Grant wedi'i gyhoeddi",
"actionContinue": "Parhau gyda’r cais",
"actionView": "Gweld cynnydd y cais",
"actionFindMore": "Dewch o hyd i ragor o wybodaeth",
Expand Down
17 changes: 10 additions & 7 deletions app/resources/cy/translation/tasklist.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
"header": "Gwneud cais am brofiant",
"introduction": "Cwblhewch y camau hyn i gael yr hawl gyfreithiol i ddelio ag eiddo rhywun sydd wedi marw.",
"paragraph1": "Gallwch arbed eich cais a dychwelyd ato hwyrach ymlaen.",
"paragraph2": "Ar ddiwedd bob adran, gofynnir ichi wirio eich atebion. Os oes unrhyw un yn anghywir, cewch gyfle i’w newid cyn mynd ymlaen i’r adran nesaf.",
"paragraph2": "Ar ddiwedd bob adran, gofynnir ichi wirio eich atebion. Os oes unrhyw un yn anghywir, cewch gyfle i’w newid cyn mynd ymlaen i’r adran nesaf. Unwaith y byddwch wedi gwneud eich datganiad cyfreithiol, bydd yn rhaid i unrhyw ddiwygiadau rydych am eu gwneud i’ch cais ar ôl yr amser hwnnw gael eu hanfon ar bapur i’r gofrestrfa.",
"taskGroup1": "Gwirio cyn i chi gychwyn",
"taskGroup2": "Paratoi’r cais",
"taskGroup3": "Cyflwyno’r cais",
"eligibilityTask": "Gwirio cymhwysedd",
"deceasedTask": "Dywedwch wrthym am yr unigolyn sydd wedi marw",
"executorsTask": "Rhowch fanylion am yr ysgutorion",
"applicantsTask": "Rhowch fanylion am y bobl sy’n gwneud cais",
Expand All @@ -12,19 +16,18 @@
"reviewAndConfirmTaskMultiplesParagraph2": "Os byddwch chi’n newid eich atebion, bydd yr ysgutorion yn gallu gweld y datganiad wedi’i ddiweddaru gan ddefnyddio’r un ddolen a gafodd ei hanfon atynt drwy e-bost.",
"reviewAndConfirmTaskMultiplesParagraph3Heading": "Ysgutorion sydd angen gwneud datganiad cyfreithiol",
"reviewAndConfirmTaskMultiplesParagraph3": "Rhaid bod pob ysgutor wedi gwneud eu datganiad cyfreithiol cyn y gallwch barhau â’ch cais.",
"copiesTaskProbate": "Archebu copïau ychwanegol o’r grant",
"copiesTaskIntestacy": "Archebu copïau ychwanegol o’r llythyrau gweinyddu",
"paymentTask": "Talu a chyflwyno eich cais",
"documentTask": "Anfon dogfennau",
"taskNotStarted": "Dechrau",
"taskStarted": "Parhau",
"checkYourAnswers": "Gwirio a newid eich atebion",
"taskNotStarted": "Heb ddechrau eto",
"taskStarted": "Yn mynd rhagddo",
"taskUnavailable": "Ni allwch ddechrau eto",
"checkYourAnswers": "Gwirio a newid eich atebion",
"taskComplete": "Wedi cwblhau",
"alreadyDeclared": "Wedi datgan yn barod",
"agreed": "Wedi cytuno",
"disagreed": "Anghytuno",
"notDeclared": "Heb ddatgan",
"executorName": "Enw’r ysgutor",
"declarationStatus": "Statws y datganiad cyfreithiol"
"declarationStatus": "Statws y datganiad cyfreithiol",
"notificationBanner": "Rhaid i bob ysgutor wneud eu datganiad cyfreithiol cyn y gallwch barhau â’ch cais."
}
6 changes: 3 additions & 3 deletions app/resources/en/translation/dashboard.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
"tableHeaderActions": "Actions",
"statusDraftProbate": "Name not entered yet",
"statusDraftIntestacy": "Name not entered yet",
"statusInProgress": "IN PROGRESS",
"statusSubmitted": "SUBMITTED",
"statusGrantIssued": "GRANT ISSUED",
"statusInProgress": "In progress",
"statusSubmitted": "Submitted",
"statusGrantIssued": "Grant issued",
"actionContinue": "Continue application",
"actionView": "View application progress",
"actionFindMore": "Find out more",
Expand Down
Loading