DTSPB-4411: Back button spike #2280
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmcts-jenkins-j-to-z
bot
added
ns:probate
prd:probate
rel:probate-frontend-pr-2280
labels
…e to display exec number
jamiealbertelli
commented
Nov 21, 2024
| @@ -4,13 +4,21 @@ | |||
| {% from "govuk/components/button/macro.njk" import govukButton %} | |||
|
|
|||
| {% block form_content %} | |||
| <h1 class="govuk-fieldset__legend--l"> | |||
There was a problem hiding this comment.
This is temporary code to conditionally display the content.question depending on whether the journey is oneOtherExec or MultipleExec. I couldn't get any expression to work in the fieldset text object, nor would a neat one-liner ternary expression work here. This is something for the full mutli-exec work assignee to think about.
jamiealbertelli
commented
Nov 25, 2024
|
|
||
|
|
||
| <pre>{{ fields | dump | safe }}</pre> | ||
|
|
There was a problem hiding this comment.
The for loop below is existing behaviour for displaying all the executors but since the logic for entering the exec name now takes place in /executor-names this needs the be worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")