DTSPB-2849 - Update playwright.yml file

hmcts · Feb 6, 2024 · c9a2805 · c9a2805
1 parent 808497e
commit c9a2805
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -4,6 +4,9 @@ on:
     branches: [ main, master ]
   pull_request:
     branches: [ main, master ]
+env:
+  PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 # Skip downloading during yarn install
+  PLAYWRIGHT_BROWSERS_PATH: 0 # Places binaries to node_modules/@playwright/test
 jobs:
   test:
     timeout-minutes: 60
@@ -14,9 +17,12 @@ jobs:
       with:
         node-version: 18
     - name: Install dependencies
-      run: npm install -g yarn && yarn
-    - name: Install Playwright Browsers
-      run: yarn playwright install --with-deps
+      run: |
+        npx playwright install-deps
+    - name: Setup
+      run: |
+        yarn install
+        yarn playwright install
     - name: Run Playwright tests
       run: yarn playwright test
     - uses: actions/upload-artifact@v3

diff --git a/Dockerfile b/Dockerfile
@@ -21,8 +21,7 @@ USER root
 RUN apk add git
 USER hmcts
 
-RUN PLAYWRIGHT_SKIP_CHROMIUM_DOWNLOAD=true && PLAYWRIGHT_BROWSERS_PATH=false yarn install
-RUN yarn playwright install
+RUN PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true yarn install
 RUN yarn -v
 RUN node -v
 RUN yarn setup-sass