-
Notifications
You must be signed in to change notification settings - Fork 3
NFDIV-4714 Applicant Options flow - Happy path #4135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: NFDIV-4713
Are you sure you want to change the base?
Conversation
…into NFDIV-4714
@@ -149,3 +149,22 @@ export const FINALISING_YOUR_APPLICATION: PageLink = '/finalising-your-applicati | |||
export const EXPLAIN_THE_DELAY: PageLink = '/explain-the-delay'; | |||
export const RESPOND_TO_COURT_FEEDBACK: PageLink = '/respond-to-the-courts-feedback'; | |||
export const REVIEW_YOUR_RESPONSE: PageLink = '/review-your-response-to-the-courts-feedback'; | |||
|
|||
export const OPTIONS_FOR_PROGRESSING: PageLink = '/general-applications/no-response/options-for-progressing'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking we could confirm the paths at some stage with Fubara/service - UCD seem to have some in the prototypes without "general-applications" in the path, but I'm not sure those prototype URLs were ever discussed. They're sometimes made snappy/short for SEO performance and to avoid truncation on mobiles, in logs etc
For example, we could have (in the code at the moment):
apply-divorce.service.gov.uk/applicant1/general-applications/no-response/options-for-progressing
apply-divorce.service.gov.uk/applicant1/general-applications/no-response/have-they-received
apply-divorce.service.gov.uk/applicant1/general-applications/deemed-service/deemed-service-application
apply-divorce.service.gov.uk/applicant1/general-applications/deemed-service/deemed-interruption
Or shortened versions:
apply-divorce.service.gov.uk/applicant1/no-response/options-for-progressing
apply-divorce.service.gov.uk/applicant1/no-response/have-they-received
apply-divorce.service.gov.uk/applicant1/deemed-service/application
apply-divorce.service.gov.uk/applicant1/deemed-service/deemed-interruption
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - it's a side effect of tidying up the step folders and grouping everything. I'm not sure if there is a way to alter the URLs without relocating the folders, but if there is I'm all for it. If not, I'd probably vote for leaving it as it is. I don't think many citizens are going to look at the URLs to these pages in the address bar, and I don't think the SEO performance hit would be that significant.
Plan Result (aat)
Change Result (Click me) # module.nfdiv-frontend-redis6.azurerm_redis_cache.redis will be updated in-place
~ resource "azurerm_redis_cache" "redis" {
id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/nfdiv-cache-aat/providers/Microsoft.Cache/redis/nfdiv-frontend-aat"
name = "nfdiv-frontend-aat"
tags = {
"application" = "no-fault-divorce"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/nfdiv-frontend.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#no-fault-divorce"
"environment" = "staging"
"managedBy" = "No Fault Divorce"
}
# (24 unchanged attributes hidden)
~ redis_configuration {
~ maxfragmentationmemory_reserved = 125 -> 642
~ maxmemory_delta = 125 -> 642
~ maxmemory_reserved = 125 -> 642
# (14 unchanged attributes hidden)
}
}
Plan: 0 to add, 1 to change, 0 to destroy. |
Plan Result (prod)
|
https://tools.hmcts.net/jira/browse/NFDIV-4714