SIDM-8901 add caseworkers #377
Conversation
hmcts-jenkins-d-to-i
bot
added
ns:idam
prd:idam
rel:idam-testing-support-api-pr-377
labels
Plan Result |
jburke-idam
force-pushed
the
SIDM-8901-caseworkers
branch
from
247b3ad to
c9c8e53
Compare
| createRequest.setSkills(Collections.emptyList()); | ||
| createRequest.setUserType("CTSC"); | ||
| createRequest.setUserProfileIdamStatus("ACTIVE"); | ||
| createRequest.setStaffAdmin(user.getRoleNames().contains("staff-admin")); |
There was a problem hiding this comment.
Would we ever want testing-support-api clients to send us things like roles, user types, regions, locations?
There was a problem hiding this comment.
Probably yes, but we don't have a "V2" model for that (yet). I think it's fine to leave these as defaults for now since IDAM is the only user. When we want to expand the usage of this we can discuss a newer input model
| ); | ||
| if (existingCaseWorkerProfile.isEmpty()) { | ||
| testingCaseWorkerProfileService.createCaseWorkerProfile(sessionId, idamUser); | ||
| } else if (existingCaseWorkerProfile.get().isSuspended() |
There was a problem hiding this comment.
Maybe we want them to be always to be the same and otherwise fail? (right now we only fail if caseworker is suspended and idam user is not)
Also - shall we look at "pending" too?
There was a problem hiding this comment.
Yeah - so since IDAM is the sole user at the moment we would always expect the entities to be created from scratch. In the event that they aren't being created we do a minimal check that the ids, emails and "status" are all in line, and fail if they aren't. I think we would need to do more with this in the long run, but this is the minimal implementation.
| return getUserProfileCategories(user.getRoleNames()); | ||
| } | ||
|
|
||
| protected Set<UserProfileCategory> getUserProfileCategories(List<String> roleNames) { |
There was a problem hiding this comment.
[minor] Probably belongs to a different class.
There was a problem hiding this comment.
yeah, I did think that. If we had an "idam library" then it could all be shared by the bridge.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/SIDM-8901
Change description
add caseworkers
Does this PR introduce a breaking change? (check one with "x")