Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Plum-fronted and Plum-recipe-backendrecipe-backend #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added Plum-fronted and Plum-recipe-backendrecipe-backend #270

wants to merge 1 commit into from

Conversation

Johns293
Copy link
Contributor

Before creating a pull request make sure that:

JIRA link (if applicable)

Added Plum-fronted and Plum-recipe-backend-recipe-backend

Change description

added plum links

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@Johns293 Johns293 requested a review from a team as a code owner February 21, 2023 16:29
timja
timja suggested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either don't add another table or update the header to include Examples for CFT and Examples for SDS

unsure really if we need a cft example there's no difference between the two these examples are for showing different ingress classes not about cft vs sds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja requested changes

@madjava madjava madjava approved these changes

@kunlebalogun kunlebalogun Awaiting requested review from kunlebalogun kunlebalogun is a code owner automatically assigned from hmcts/platform-operations

@DJ-Khaled DJ-Khaled Awaiting requested review from DJ-Khaled DJ-Khaled is a code owner automatically assigned from hmcts/platform-operations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Johns293 @madjava @timja