Dfr 2689 auto date pension sharing annex #1944
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 40dbf6d.
Plan Result (aat) |
Plan Result (prod) |
al-hmcts
reviewed
Nov 13, 2024
| && (acroForm.get().getField(FORM_P1_DATE_OF_ORDER_TEXTBOX_NAME) instanceof PDTextField)) { | ||
| PDField field = acroForm.get().getField(FORM_P1_DATE_OF_ORDER_TEXTBOX_NAME); | ||
| PDTextField textBox = (PDTextField) field; | ||
| textBox.setDefaultAppearance("/Helv 12 Tf 0 g"); |
There was a problem hiding this comment.
Are we sure we want to add this font in? Can we not used any embedded font, we saw on the D11 that this font was marked as not embedded on the pre-flight tool. Could we use a font already on the PDF?
jthmcts
reviewed
Nov 13, 2024
| @@ -132,4 +133,25 @@ private Boolean isPensionDocumentsEmpty(Map<String, Object> caseData) { | |||
| List<CaseDocument> pensionDocumentsData = documentHelper.getPensionDocumentsData(caseData); | |||
| return pensionDocumentsData.isEmpty(); | |||
| } | |||
|
|
|||
| private static LocalDate getApprovalDate(Map<String, Object> caseData) { | |||
There was a problem hiding this comment.
This method doesn't need to be static
jthmcts
reviewed
Nov 13, 2024
| try { | ||
| return LocalDate.parse((String) value); | ||
| } catch (Exception e) { | ||
| log.info("Invalid Approved date of order for key '" + caseData + "': " + e.getMessage()); |
There was a problem hiding this comment.
It looks like you are outputting the whole caseData map in the log message. Is this a good idea? Same comment for line 153
jthmcts
reviewed
Nov 13, 2024
| } | ||
| } | ||
|
|
||
| private void verifyNoDateOfOrderField(byte[] bytes) throws IOException { |
There was a problem hiding this comment.
The last two methods aren't being used. They should be removed.
jthmcts
reviewed
Nov 13, 2024
| } | ||
|
|
||
| private void verifyDateOfOrderField(byte[] bytes) throws IOException { | ||
| try (PDDocument document = Loader.loadPDF(bytes)) { |
There was a problem hiding this comment.
SonarLint complains about "document" in the IDE:
Rename "document" which hides the field declared at line 51.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
https://tools.hmcts.net/jira/browse/DFR-2689
Change description
Auto date document - pension sharing annex