DMP-2948: Encoding Event element as escaped string #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonymort
force-pushed
the
DMP-2948-encode-event-element
branch
from
9427011 to
b9504ed
Compare
jackmaloney
reviewed
Apr 25, 2024
| @@ -31,15 +33,15 @@ public class DarNotifyEventServiceImpl implements DarNotifyEventService { | |||
| @Override | |||
| public void darNotify(DarNotifyEvent darNotifyEvent) { | |||
| if (enableDarNotify) { | |||
| DARNotifyEvent xmlDarNotifyEvent = convertToXmlDarNotifyEvent(darNotifyEvent); | |||
| darNotifyEventClient.darNotifyEvent(darNotifyEvent.getNotificationUrl(), xmlDarNotifyEvent); | |||
| var eventAsXml = createEvent(darNotifyEvent); | |||
There was a problem hiding this comment.
Is this Xml? If not, maybe rename var
tonymort
force-pushed
the
DMP-2948-encode-event-element
branch
from
bb6ac94 to
20c3c74
Compare
jackmaloney
reviewed
Apr 25, 2024
| @@ -0,0 +1,36 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
| <xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"> | |||
There was a problem hiding this comment.
2 very similar schemas in this folder. If both are needed, maybe add a comment to this file to make clear to a future developer why we need both and what the difference is.
jackmaloney
approved these changes
Apr 25, 2024
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-gateway-pr-383
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tools.hmcts.net/jira/browse/DMP-2948
Encoding Event element as escaped string
Does this PR introduce a breaking change? (check one with "x")