Dmp 2949 dar notify response maps to success #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-paniccia
force-pushed
the
dmp-2949-dar-notify-response-maps-to-success
branch
from
f981070 to
2538e57
Compare
mario-paniccia
commented
Apr 25, 2024
| @@ -25,6 +25,7 @@ public HttpComponentsMessageSender httpComponentsMessageSender() { | |||
| public Jaxb2Marshaller marshaller() { | |||
| var marshaller = new Jaxb2Marshaller(); | |||
| marshaller.setPackagesToScan("com.viqsoultions"); | |||
| marshaller.setValidationEventHandler(new jakarta.xml.bind.helpers.DefaultValidationEventHandler()); | |||
There was a problem hiding this comment.
without this, any unmarshalling error won't be thrown as an exception. Unmarshalling will silently fail instead and leave fields with unmarshalling issues to null
jackmaloney
requested changes
Apr 25, 2024
src/integrationTest/java/uk/gov/hmcts/darts/event/controller/DarNotifyControllerTest.java
Show resolved
Hide resolved
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-gateway-pr-382
labels
mario-paniccia
force-pushed
the
dmp-2949-dar-notify-response-maps-to-success
branch
from
b50b745 to
4158d72
Compare
jackmaloney
approved these changes
Apr 25, 2024
mario-paniccia
force-pushed
the
dmp-2949-dar-notify-response-maps-to-success
branch
from
4a4386e to
1635639
Compare
mario-paniccia
force-pushed
the
dmp-2949-dar-notify-response-maps-to-success
branch
from
1635639 to
bdab0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.