DMP-4613 Add ARM RPO check for getExtendedProductionsByMatter status #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-hedges
force-pushed
the
DMP-4613-AddARMRPOCheckGetExtendedProductionsByMatterStatus
branch
from
f5ead64 to
4857e52
Compare
karen-hedges
force-pushed
the
DMP-4613-AddARMRPOCheckGetExtendedProductionsByMatterStatus
branch
2 times, most recently
from
1e2ec04 to
228607d
Compare
karen-hedges
force-pushed
the
DMP-4613-AddARMRPOCheckGetExtendedProductionsByMatterStatus
branch
from
1a3a655 to
3b7cd65
Compare
karen-hedges
requested review from
davet1985,
jackmaloney,
hemantasharma1129,
c4seyla,
ozzyib and
manohar-hmcts
and removed request for
a team
karen-hedges
force-pushed
the
DMP-4613-AddARMRPOCheckGetExtendedProductionsByMatterStatus
branch
from
971095a to
99b7bf9
Compare
chrisbellingham-hmcts
approved these changes
Jan 22, 2025
src/main/java/uk/gov/hmcts/darts/arm/rpo/impl/ArmRpoApiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/arm/rpo/impl/ArmRpoApiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/arm/rpo/impl/ArmRpoApiImpl.java
Outdated
Show resolved
Hide resolved
karen-hedges
force-pushed
the
DMP-4613-AddARMRPOCheckGetExtendedProductionsByMatterStatus
branch
from
bc7ea13 to
84ee082
Compare
hemantasharma1129
approved these changes
Jan 22, 2025
karen-hedges
force-pushed
the
DMP-4613-AddARMRPOCheckGetExtendedProductionsByMatterStatus
branch
from
50eb87e to
eb73834
Compare
1) Add to the ARM RPO getExtendedProductionsByMatter object status and check that it is either 4 or 5. 4 represents READY 5 represents CONNECTION_ERROR If neither status don't move on, just keep as in-progress. 2) Add getExtendedProductionsByMatter in-progress to re-polling states 3) Fix bug where first search name is being return by getExtendedSearchesByMatter instead of the matching search items name 4) Change getExtendedProductionsByMatter to not return the production id of the first production but the one that matches the search name for point 3.
Added extra changes
Added missing new exception
Added missing new exception
Added missing new exception
Added missing new exception
Fixed sonar complaint
Fixed sonar complaint
Fixed sonar complaint
Fixed sonar complaint
karen-hedges
force-pushed
the
DMP-4613-AddARMRPOCheckGetExtendedProductionsByMatterStatus
branch
from
eb73834 to
1d8d89f
Compare
karen-hedges
deleted the
DMP-4613-AddARMRPOCheckGetExtendedProductionsByMatterStatus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-4613
Change description
From the response, extract the Production Id using the "name" attribute which is Production Id. If not found try again in next execution.
If found, check 'endProductionTime' is not null. If null then the ARM job is not finished and try again in next execution.
From the response extract productionExportFile.status
Since we can have multiple productionExportFile objects we will have to handle the following scenarios :
CSVs are still running [1]: In Progress so try again in next execution.
CSVs are all reported as success [4]: The job was a complete success. Download.
CSVs are all a failure [not 1 or 4]: The job was a complete failure. Investigate.
CSVs are partially a success, partially a failure [mixture of 4s and not 4/1s]: Partially process and the failed CSV objects will be marked as ARM_REPLAY.
3. Add getExtendedProductionsByMatter & getProductionOutputFiles in-progress to re-polling states
Does this PR introduce a breaking change? (check one with "x")