DMP-4385 Filter out 0 second audios from ATS processing #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-hedges
requested review from
davet1985,
jackmaloney,
cakeben,
akozichev,
DanielKChristou and
ieuanb74
and removed request for
a team
src/main/java/uk/gov/hmcts/darts/audio/component/impl/OutboundFileProcessorImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AudioTransformationServiceImpl.java
Show resolved
Hide resolved
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2408
labels
karen-hedges
force-pushed
the
DMP-4385-Filter0SecondAudios
branch
from
4bbcff3 to
78daf81
Compare
jackmaloney
reviewed
Jan 3, 2025
src/main/java/uk/gov/hmcts/darts/audio/component/impl/OutboundFileProcessorImpl.java
Outdated
Show resolved
Hide resolved
karen-hedges
force-pushed
the
DMP-4385-Filter0SecondAudios
branch
from
eaf0d8f to
b06888f
Compare
jackmaloney
reviewed
Jan 3, 2025
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AudioTransformationServiceImpl.java
Outdated
Show resolved
Hide resolved
jackmaloney
reviewed
Jan 3, 2025
src/main/java/uk/gov/hmcts/darts/audio/service/impl/AudioTransformationServiceImpl.java
Show resolved
Hide resolved
jackmaloney
approved these changes
Jan 3, 2025
Ben-Edwards-cgi
approved these changes
Jan 6, 2025
karen-hedges
force-pushed
the
DMP-4385-Filter0SecondAudios
branch
from
f860b83 to
27eb0c7
Compare
hemantasharma1129
approved these changes
Jan 6, 2025
karen-hedges
force-pushed
the
DMP-4385-Filter0SecondAudios
branch
from
27eb0c7 to
89df882
Compare
karen-hedges
force-pushed
the
DMP-4385-Filter0SecondAudios
branch
from
89df882 to
84ab066
Compare
Updated the ATS filtering to filter out audio files that have less than a second start and end time, start or end time is null or start time is after end time
Updated the ATS filtering to filter out audio files that have less than a second start and end time, start or end time is null or start time is after end time
Added tests for ATS filtering to filter out audio files that have less than a second apart
Added tests for ATS filtering to filter out audio files that have less than a second apart
Added tests for ATS filtering to filter out audio files that have less than a second apart
Added tests for ATS filtering to filter out audio files that have less than a second apart
karen-hedges
force-pushed
the
DMP-4385-Filter0SecondAudios
branch
from
84ab066 to
da7ac7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-4385
Change description
Updated the ATS filtering to filter out audio files that have less than a second start and end time, start or end time is null or start time is after end time
Does this PR introduce a breaking change? (check one with "x")