Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMP-4324: Dev Only: Resolve Flaky Embedded Wiremock Integration Tests #2405

Merged
merged 19 commits into from
Jan 6, 2025

Conversation

Ben-Edwards-cgi
Copy link
Contributor

Links

Jira

Change description

Under src/integrationTest/java/uk/gov/hmcts/darts/arm/client, we have test ArmRpoClientIntTest which is intended to verify the Feign client calls (defined by ArmRpoClient) are working correctly.

However the tests are currently disabled because renabling them causes intermittent failures for other tests within the uk/gov/hmcts/darts/arm/client, which are only apparent when running the full test suite (or all tests within the uk/gov/hmcts/darts/arm/client package).

So this task is to:

  • Renable the ArmRpoClientIntTests, and fix the intermittment failures
  • Add new tests to ensure all methods within ArmRpoClient are covered by wiremock integration tests.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

@Ben-Edwards-cgi Ben-Edwards-cgi requested review from a team as code owners January 2, 2025 10:07
@Ben-Edwards-cgi Ben-Edwards-cgi marked this pull request as draft January 2, 2025 10:07
@Ben-Edwards-cgi Ben-Edwards-cgi marked this pull request as ready for review January 2, 2025 17:17
@Ben-Edwards-cgi Ben-Edwards-cgi enabled auto-merge (squash) January 3, 2025 14:18
@Ben-Edwards-cgi Ben-Edwards-cgi merged commit f234a1f into master Jan 6, 2025
10 checks passed
@Ben-Edwards-cgi Ben-Edwards-cgi deleted the DMP-4324 branch January 6, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants