generated from hmcts/spring-boot-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMP-4324: Dev Only: Resolve Flaky Embedded Wiremock Integration Tests #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Edwards-cgi
requested review from
davet1985,
jackmaloney,
hemantasharma1129,
SalimKainos,
ishdeepdulkoan and
jyothi-balla
and removed request for
a team
January 2, 2025 10:07
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2405
labels
Jan 2, 2025
hemantasharma1129
approved these changes
Jan 3, 2025
jackmaloney
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Change description
Under
src/integrationTest/java/uk/gov/hmcts/darts/arm/client
, we have test ArmRpoClientIntTest which is intended to verify the Feign client calls (defined by ArmRpoClient) are working correctly.However the tests are currently disabled because renabling them causes intermittent failures for other tests within the
uk/gov/hmcts/darts/arm/client
, which are only apparent when running the full test suite (or all tests within theuk/gov/hmcts/darts/arm/client
package).So this task is to:
Does this PR introduce a breaking change? (check one with "x")