generated from hmcts/spring-boot-template
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMP-3534: Retention Confidence #2382
Open
chrisbellingham-hmcts
wants to merge
10
commits into
master
Choose a base branch
from
dmp-3534-retention-confidence-category-mapper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DMP-3534: Retention Confidence #2382
chrisbellingham-hmcts
wants to merge
10
commits into
master
from
dmp-3534-retention-confidence-category-mapper
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbellingham-hmcts
force-pushed
the
dmp-3534-retention-confidence-category-mapper
branch
from
December 18, 2024 12:13
0b674db
to
a78340f
Compare
chrisbellingham-hmcts
force-pushed
the
dmp-3534-retention-confidence-category-mapper
branch
from
December 18, 2024 12:15
a78340f
to
7eaab33
Compare
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-api-pr-2382
labels
Dec 18, 2024
src/test/java/uk/gov/hmcts/darts/cases/service/impl/CloseOldCasesProcessorImplTest.java
Show resolved
Hide resolved
src/test/java/uk/gov/hmcts/darts/retention/service/impl/RetentionPostServiceImplTest.java
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/darts/retention/enums/RetentionConfidenceScoreEnum.java
Show resolved
Hide resolved
chrisbellingham-hmcts
requested review from
davet1985,
jackmaloney,
cakeben,
c4seyla,
cpareek and
mananpatel26
and removed request for
a team
December 18, 2024 13:54
src/main/java/uk/gov/hmcts/darts/common/entity/RetentionConfidenceCategoryMapperEntity.java
Show resolved
Hide resolved
…g value for confidenceReason; add associated test
jackmaloney
reviewed
Dec 18, 2024
src/integrationTest/java/uk/gov/hmcts/darts/cases/service/CloseOldCasesProcessorTest.java
Outdated
Show resolved
Hide resolved
jackmaloney
reviewed
Dec 18, 2024
src/integrationTest/java/uk/gov/hmcts/darts/cases/service/CloseOldCasesProcessorTest.java
Show resolved
Hide resolved
hemantasharma1129
approved these changes
Dec 19, 2024
jackmaloney
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DMP-3534
Two fundamental changes in this PR:
src/main/java/uk/gov/hmcts/darts/retention/enums/RetentionConfidenceScoreEnum.java
retention_confidence_category_mapper
to obtain these values. Seesrc/main/java/uk/gov/hmcts/darts/retention/service/impl/RetentionServiceImpl.java
Some additional work has been done to facilitate these changes:
RetentionConfidenceCategoryMapperEntity
has been updated to utilise enums rather than ints, improving code readability and aligning with the approach taken forCaseRetentionEntity
andCourtCaseEntity
.RetentionServiceImpl
, and calling code has been adjusted to share this common code.RetentionConfidenceCategoryMapperEntity
objects for both unit and integration tests going forward.Does this PR introduce a breaking change? (check one with "x")