DMP-4613 Add ARM RPO check for getExtendedProductionsByMatter status

Fixed sonar complaint
hmcts · Jan 22, 2025 · dbe917d · dbe917d
1 parent 02afee2
commit dbe917d
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/main/java/uk/gov/hmcts/darts/arm/service/impl/ArmRpoPollServiceImpl.java b/src/main/java/uk/gov/hmcts/darts/arm/service/impl/ArmRpoPollServiceImpl.java
@@ -209,12 +209,9 @@ private boolean pollServiceFailed(ArmRpoExecutionDetailEntity armRpoExecutionDet
     }
 
     private boolean pollServiceInProgress(ArmRpoExecutionDetailEntity armRpoExecutionDetail) {
-        if (nonNull(armRpoExecutionDetail.getArmRpoState())
+        return nonNull(armRpoExecutionDetail.getArmRpoState())
             && ArmRpoHelper.inProgressRpoStatus().getId().equals(armRpoExecutionDetail.getArmRpoStatus().getId())
-            && allowableInProgressStates.contains(armRpoExecutionDetail.getArmRpoState().getId())) {
-            return true;
-        }
-        return false;
+            && allowableInProgressStates.contains(armRpoExecutionDetail.getArmRpoState().getId());
     }
 
     private boolean saveBackgroundSearchCompleted(ArmRpoExecutionDetailEntity armRpoExecutionDetailEntity) {