Updated PMD main rules (#2325)

hmcts · Nov 27, 2024 · b0a7c92 · b0a7c92
1 parent 466480b
commit b0a7c92
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/build.gradle b/build.gradle
@@ -230,7 +230,7 @@ pmd {
 pmdMain {
   ruleSetFiles = files("config/pmd/main-ruleset.xml")
   //Ensures we don't passively increase pmd errors but we should aim to reduce this
-  maxFailures = 1338
+  maxFailures = 605
 }
 
 pmdTestCommon {

diff --git a/config/pmd/main-ruleset.xml b/config/pmd/main-ruleset.xml
@@ -9,7 +9,7 @@
   <rule ref="category/java/bestpractices.xml">
     <exclude name="GuardLogStatement"/>
     <exclude name="UnitTestContainsTooManyAsserts"/>
-    <exclude name="JUnitAssertionsShouldIncludeMessage"/>
+    <exclude name="UnitTestAssertionsShouldIncludeMessage"/>
     <exclude name="UnitTestShouldIncludeAssert"/>
   </rule>
   <rule ref="category/java/codestyle.xml">
@@ -21,6 +21,7 @@
     <exclude name="TooManyStaticImports"/>
     <exclude name="CommentDefaultAccessModifier"/>
     <exclude name="LinguisticNaming"/>
+    <exclude name="UseExplicitTypes"/>
   </rule>
   <rule ref="category/java/codestyle.xml/ClassNamingConventions">
     <properties>
@@ -54,6 +55,7 @@
   <rule ref="category/java/design.xml/LawOfDemeter">
     <properties>
       <property name="violationSuppressRegex" value="(.*method chain calls.*|.*object not created locally.*)"/>
+      <property name="trustRadius" value="2"/>
     </properties>
   </rule>
   <rule ref="category/java/design.xml/SignatureDeclareThrowsException">