Add nagger warning about default sku change in redis module #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
suggested changes
Oct 5, 2023
| @@ -0,0 +1,15 @@ | |||
| #!/bin/bash | |||
|
|
|||
| output=$(grep -R --include=*.tf "hmcts/cnp-module-redis" | wc -l) | |||
There was a problem hiding this comment.
🚫 this needs to check whether they have configured the sku
| ./check-redis-sku.sh | ||
| """ | ||
| } catch(ignored) { | ||
| WarningCollector.addPipelineWarning("Default Redis Sku has Changed to Basic", "Please follow instruction in https://github.com/hmcts/cnp-module-redis/blob/mokainos-patch-1/README.md ", LocalDate.of(2023, 11, 11)) |
There was a problem hiding this comment.
this should provide an example pull request
Co-authored-by: Tim Jacomb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # . (This is applicable only if this pull request relates to a GitHub issue, delete the line otherwise)
Notes:
*
*
*