Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTSCCI-1440 Remove character limit for the Claim Summary and Defence Summary #5403

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

DTSCCI-1440 Remove character limit for the Claim Summary and Defence Summary #5403

wants to merge 4 commits into from
+1 −4

Conversation

anirudha-deshpande
Copy link

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@anirudha-deshpande anirudha-deshpande requested a review from a team as a code owner January 14, 2025 11:46
@anirudha-deshpande anirudha-deshpande requested review from hemantt and sankaviv1 and removed request for a team January 14, 2025 11:46
@anirudha-deshpande anirudha-deshpande changed the title DTSCCI-1440: Remove character limit for the Claim Summary and Defence Summary DTSCCI-1440 Remove character limit for the Claim Summary and Defence Summary Jan 14, 2025
@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview January 14, 2025 12:00 Abandoned
peterpilgrim
peterpilgrim previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@peterpilgrim peterpilgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

velimd
velimd reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@velimd velimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however, are there any test for this that needs to be removed?

rishikrsharma
rishikrsharma previously approved these changes Jan 15, 2025
View reviewed changes
@anirudha-deshpande
Copy link
Author

LGTM however, are there any test for this that needs to be removed?

No tests around this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velimd velimd velimd approved these changes

@rishikrsharma rishikrsharma rishikrsharma approved these changes

@peterpilgrim peterpilgrim peterpilgrim left review comments

@hemantt hemantt Awaiting requested review from hemantt hemantt is a code owner automatically assigned from hmcts/civil-admins

@sankaviv1 sankaviv1 Awaiting requested review from sankaviv1 sankaviv1 is a code owner automatically assigned from hmcts/civil-admins

Assignees
No one assigned
Labels
enable_keep_helm fullDeploy ns:civil pr-values:elasticsearch prd:civil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anirudha-deshpande @peterpilgrim @rishikrsharma @velimd @pats-john