enable fortify failure (#2447)

* enable fortify failure * Update Jenkinsfile_CNP * Update Jenkinsfile_nightly --------- Co-authored-by: ankita-srivastava009 <[email protected]>
hmcts · Aug 13, 2024 · afd1854 · afd1854
1 parent 5e64e79
commit afd1854
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Jenkinsfile_CNP b/Jenkinsfile_CNP
@@ -112,6 +112,8 @@ env.BEFTA_RETRY_MAX_ATTEMPTS = "3"
 env.BEFTA_RETRY_STATUS_CODES = "500,502,503,504"
 env.BEFTA_RETRY_MAX_DELAY = "1000"
 env.BEFTA_RETRY_NON_RETRYABLE_HTTP_METHODS = "POST,PUT"
+// Prevent Docker hub rate limit errors by ensuring that testcontainers uses images from hmctspublic ACR
+env.TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX = "hmctspublic.azurecr.io/imported/"
 
 withPipeline(type, product, component) {
     onMaster {

diff --git a/Jenkinsfile_nightly b/Jenkinsfile_nightly
@@ -81,6 +81,8 @@ def vaultOverrides = [
 // vars needed for functional tests
 // Assume a feature build branched off 'develop', with dependencies develop-to-develop.
 env.TEST_URL = "http://ccd-data-store-api-aat.service.core-compute-aat.internal"
+// Prevent Docker hub rate limit errors by ensuring that testcontainers uses images from hmctspublic ACR
+env.TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX = "hmctspublic.azurecr.io/imported/"
 
 // Other env variables needed for BEFTA.
 env.BEFTA_S2S_CLIENT_ID = "ccd_gw"

diff --git a/build.gradle b/build.gradle
@@ -807,8 +807,6 @@ task fortifyScan(type: JavaExec)  {
     mainClass = "uk.gov.hmcts.fortifyclient.FortifyClientMainApp"
     classpath += sourceSets.test.runtimeClasspath
     jvmArgs = ['--add-opens=java.base/java.lang.reflect=ALL-UNNAMED']
-    // The line below prevents the build from failing if the Fortify scan detects issues
-    ignoreExitValue = true
 }
 
 idea {