Fix/exui 2744 #1857
Open
Fix/exui 2744 #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MunishSharmaHMCTS
previously approved these changes
Feb 10, 2025
RiteshHMCTS
reviewed
Feb 10, 2025
RiteshHMCTS
reviewed
Feb 12, 2025
| } | ||
| } | ||
| } else { | ||
| if (caseField.data[fieldId] !== data[field].formatted_value){ |
There was a problem hiding this comment.
@Josh-HMCTS can the above if condition can be added in the else block above
There was a problem hiding this comment.
move to be else if, not nested if on its own
| formattedValue[key] = dataValue; | ||
| } else if (formattedValue[key] !== dataValue) { | ||
| formattedValue[key] = dataValue; | ||
| } |
There was a problem hiding this comment.
@Josh-HMCTS can above check can be clubbed in if block?
There was a problem hiding this comment.
moved to use one if statement with ||
|
StoneBenHMCTS
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2744
Change description
Handle collections that consist of dynamic multi select lists in the collection's complex type