exui-2085-passing flag to differentiate task completed by event (#1753)

* passing flag to differentiate task completed by event * added extra param to differentiate task completion through the event * version updated
hmcts · Aug 5, 2024 · d21086e · d21086e
1 parent 7927b01
commit d21086e
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 6 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -1,8 +1,15 @@
 ## RELEASE NOTES
 
+
+### Version 7.0.54
+**EXUI-2085** Add Task completion logs in app insight
+
 ### Version 7.0.53
 **EXUI-1540** revert this change
 
+### Version 7.0.52
+**EXUI-1117** Improve robustness to malformed dynamic list data
+
 ### Version 7.0.51
 **EXUI-2051** Unable to Add documents
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hmcts/ccd-case-ui-toolkit",
-  "version": "7.0.53",
+  "version": "7.0.54",
   "engines": {
     "node": ">=18.19.0"
   },

diff --git a/projects/ccd-case-ui-toolkit/package.json b/projects/ccd-case-ui-toolkit/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@hmcts/ccd-case-ui-toolkit",
-  "version": "7.0.53",
+  "version": "7.0.54",
   "engines": {
     "node": ">=18.19.0"
   },

diff --git a/...ui-toolkit/src/lib/shared/components/case-editor/services/work-allocation.service.spec.ts b/...ui-toolkit/src/lib/shared/components/case-editor/services/work-allocation.service.spec.ts
@@ -221,7 +221,7 @@ describe('WorkAllocationService', () => {
 
     it('should call post with the correct parameters', () => {
       workAllocationService.completeTask(MOCK_TASK_1.id).subscribe();
-      expect(httpService.post).toHaveBeenCalledWith(TASK_COMPLETE_URL, {});
+      expect(httpService.post).toHaveBeenCalledWith(TASK_COMPLETE_URL, { actionByEvent: true });
     });
 
     it('should set error service error when the call fails', (done) => {
@@ -255,7 +255,7 @@ describe('WorkAllocationService', () => {
 
     it('should call post with the correct parameters', () => {
       workAllocationService.assignAndCompleteTask(MOCK_TASK_1.id).subscribe();
-      expect(httpService.post).toHaveBeenCalledWith(TASK_COMPLETE_URL, {completion_options: {assign_and_complete: true}});
+      expect(httpService.post).toHaveBeenCalledWith(TASK_COMPLETE_URL, {completion_options: {assign_and_complete: true}, actionByEvent: true});
     });
 
     it('should set error service error when the call fails', (done) => {

diff --git a/...case-ui-toolkit/src/lib/shared/components/case-editor/services/work-allocation.service.ts b/...case-ui-toolkit/src/lib/shared/components/case-editor/services/work-allocation.service.ts
@@ -105,7 +105,7 @@ export class WorkAllocationService {
     console.log(`completeTask: completing ${taskId}`);
     const url = `${this.appConfig.getWorkAllocationApiUrl()}/task/${taskId}/complete`;
     return this.http
-      .post(url, {})
+      .post(url, { actionByEvent: true })
       .pipe(
         catchError(error => {
           this.errorService.setError(error);
@@ -131,7 +131,8 @@ export class WorkAllocationService {
       .post(url, {
         completion_options: {
           assign_and_complete: true
-        }
+        },
+        actionByEvent: true
       })
       .pipe(
         catchError(error => {