Skip to content

Commit

Permalink
fix some config errors and external url (#124)
Browse files Browse the repository at this point in the history
* fix some errors (external url and syntax errors) in the apps.yml file
charlesluokb authored Dec 20, 2023

Verified

This commit was signed with the committer’s verified signature.
rhennigan Rick Hennigan
1 parent 3ff8a46 commit fdaa203
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ yarn node --enable-source-maps lib/main.js --config apps.yaml
### Tests

Login to Azure with an account that has the Application Administrator role in the tenant.
It's recommended you use a sandbox tenant for this.
It's recommended you use a sandbox tenant (e.g. E5 SANDBOX) for this.

Then run:

8 changes: 4 additions & 4 deletions apps.yaml
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@

apps:
- name: "My app101"
externalUrl: "https://my-test-app-app-proxy-poc.hmcts.net"
externalUrl: "https://my-test-app.app-proxy-poc.sandbox.platform.hmcts.net"
logoUrl: https://raw.githubusercontent.com/hmcts/azure-app-proxy/main/logos/incident-bot.png
appRoleAssignments:
- Test app
@@ -18,10 +18,10 @@ apps:
optionalClaims:
- name: "groups"
additionalProperties: []
graphApiPermissions::
graphApiPermissions:
- "User.Read.All"
- "Group.Read.All"
- "People.Read"
clientSecret:
+ name: test-jenkins
+ key_vault_name: cftsbox-intsvc
name: test-jenkins
key_vault_name: cftsbox-intsvc

0 comments on commit fdaa203

Please sign in to comment.