Aaron Stringer-Usdan #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Now that I've got the whole thing working, it seems to have a lot of the features you'd want in a DSL. From a strictly theoretical point of view, you can write any regular expression you could want. All the operators are there, and represented by no more than three characters, too (unless you count the number of characters in the number _n_ you supply to the repetition operator). | ||
|
|
||
| However, the formal mathematical definition of regular expressions doesn't have wildcard characters so far as I can recall, and neither does this DSL. It _is_ possible to get a wildcard expression by taking the union of all characters that could possibly be matched against, but this is _really_ not practical for someone using the DSL. | ||
|
|
There was a problem hiding this comment.
I don't think we should be too concerned about the formal mathematical definition of regular expressions. What's important is making it easy for users to write regular expressions, and I agree that adding wildcards would be a good next step. In addition to the general wildcard, it could also be nice to have symbols that would match against all digits, all letters, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.