Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Feature virtual dom transform #46

Merged
merged 25 commits into from
Oct 7, 2024

Conversation

FelipeSimoes
Copy link
Collaborator

1 - Virtual dom transformations by reducer
2 - Removal of component loader
3 - Updates on Component Base
4 - Updates on the grid in favor of CSS variables and one-level grid

Test URLs:

Copy link

aem-code-sync bot commented Sep 27, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 27, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform September 27, 2024 15:28 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform September 27, 2024 15:30 Inactive
@@ -354,7 +358,16 @@ export function mergeUniqueArrays(...arrays) {
}

export function getBaseUrl() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have removed the usage of basepath in this PR #29

Should this be brought back?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since on the other SharePoint configs are different, making things break when we have fixed paths like before


export default class ComponentBase extends HTMLElement {
// All supported data attributes must be added to observedAttributes
// The order of observedAttributes is the order in which the values from config are added.
static observedAttributes = [];

dataAttributesKeys = [];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved in the setDefaults() method for consistency

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, all those should be class properties.
To make sure they are defined before the constructor, for instance, if we need to override a property from HTMLElement that need to be set as normal OOP class prop before super is called

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my tests in the begining that worked as it was before, we could change from an element directly any of these properties.

And for config and nestedComponentsConfig which we are extending in components keeping the defaults from base, the extension failed if these were class fields.

@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform September 27, 2024 15:42 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform September 27, 2024 16:02 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform September 27, 2024 17:07 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform September 27, 2024 17:12 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform September 27, 2024 17:13 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform September 27, 2024 17:18 Inactive
blocks/grid/grid.editor.js Outdated Show resolved Hide resolved
blocks/grid/grid.editor.js Outdated Show resolved Hide resolved
blocks/grid/grid.editor.js Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to feature-virtual-dom-transform October 7, 2024 07:49 Inactive
@FelipeSimoes FelipeSimoes merged commit 4ce7c1f into main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants