Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrollbars, popup and dataset and component init #35

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Conversation

infloent
Copy link
Collaborator

@infloent infloent commented Aug 9, 2024

Test URLs:

Fixes the scrollbars on windows

Fixes the popup and due to the changes for external config the support for https://github.com/hlxsites/henkel-raqn-guide/blob/main/blocks/popup/config-popup.md had to be removed.

We will need a separate ticket to find another way to add config the popup

To fix the popup some general fixes were applied to component base:

  • how data attributes are added by applyData() to prevent double trigger of attribute change listeners
  • and setting initial attributesValues.all if the element already has data attributes added before this.init() or this.initOnConnected() are run;

test page for popup - all will be modals no more flyout due to the removal of the popup-config.

Copy link

aem-code-sync bot commented Aug 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 9, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@infloent infloent changed the title Fix scrollbars Fix scrollbars, popup and dataset and component init Aug 9, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to fix-scrollbars August 9, 2024 13:55 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-scrollbars August 9, 2024 14:01 Inactive
; Conflicts:
;	scripts/libs.js
@aem-code-sync aem-code-sync bot temporarily deployed to fix-scrollbars August 19, 2024 13:02 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to fix-scrollbars August 19, 2024 13:02 Inactive
@infloent infloent merged commit 9ef6085 into main Aug 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants